From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AE1C76186 for ; Sat, 27 Jul 2019 22:00:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 465FF208E4 for ; Sat, 27 Jul 2019 22:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564264828; bh=zWPkpNnPHxtvxmzY7Kf5pjMpiNZzco8IfGo8yKf0EiU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=pnj4IRJ8ZTthpPVBN5qsE4A86e/RBxR3J251QarbzKqO55TGVTLhoYQbrB+P8YkKg KecWe3Muwhf1cPOM9aKqt5TagLtxT7awMa7i5mxBlYNEwNSXzvMZnsviWgyPGQzGDO pqhQ00uOMJ/nPLnpYNIMYK5xpxGre6/qDtqDD9+0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727733AbfG0WA1 (ORCPT ); Sat, 27 Jul 2019 18:00:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:35970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725263AbfG0WA1 (ORCPT ); Sat, 27 Jul 2019 18:00:27 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 12A3E2085A; Sat, 27 Jul 2019 22:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564264826; bh=zWPkpNnPHxtvxmzY7Kf5pjMpiNZzco8IfGo8yKf0EiU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pqUn6gKHJy3xyrSsNHIhKNMl7becKG6bzIhXNOAhvH+g0yAyRU3LC5zHOndILRd3o Ahc+kZm4msblm7VWCHA41ux+GQn4yZNkRgHakviDhvXXXepqDsz/PlkeSffGTe8pqY h1tSVGqqnkWPY/zA/PArUtj3bQ2lJ2D19FPqzV1Q= Date: Sat, 27 Jul 2019 23:00:21 +0100 From: Jonathan Cameron To: Gwendal Grignou Cc: bleung@chromium.org, enric.balletbo@collabora.com, groeck@chromium.org, fabien.lahoudere@collabora.com, dianders@chromium.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/4] iio: cros_ec: Add sign vector in core for backward compatibility Message-ID: <20190727230021.4e7f90f9@archlinux> In-Reply-To: <20190715231454.189459-2-gwendal@chromium.org> References: <20190715231454.189459-1-gwendal@chromium.org> <20190715231454.189459-2-gwendal@chromium.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 15 Jul 2019 16:14:51 -0700 Gwendal Grignou wrote: > To allow cros_ec iio core library to be used with legacy device, add a > vector to rotate sensor data if necessary: legacy devices are not > reporting data in HTML5/Android sensor referential. > > Check the data is not rotated on recent chromebooks that use the HTML5 > standard to present sensor data. > > Signed-off-by: Gwendal Grignou > Reviewed-by: Douglas Anderson Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 4 ++++ > include/linux/iio/common/cros_ec_sensors_core.h | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > index 719a0df5aeeb..e8a4d78659c8 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > @@ -66,6 +66,9 @@ int cros_ec_sensors_core_init(struct platform_device *pdev, > } > state->type = state->resp->info.type; > state->loc = state->resp->info.location; > + > + /* Set sign vector, only used for backward compatibility. */ > + memset(state->sign, 1, CROS_EC_SENSOR_MAX_AXIS); > } > > return 0; > @@ -254,6 +257,7 @@ static int cros_ec_sensors_read_data_unsafe(struct iio_dev *indio_dev, > if (ret < 0) > return ret; > > + *data *= st->sign[i]; > data++; > } > > diff --git a/include/linux/iio/common/cros_ec_sensors_core.h b/include/linux/iio/common/cros_ec_sensors_core.h > index ce16445411ac..a1c85ad4df91 100644 > --- a/include/linux/iio/common/cros_ec_sensors_core.h > +++ b/include/linux/iio/common/cros_ec_sensors_core.h > @@ -71,6 +71,7 @@ struct cros_ec_sensors_core_state { > enum motionsensor_location loc; > > s16 calib[CROS_EC_SENSOR_MAX_AXIS]; > + s8 sign[CROS_EC_SENSOR_MAX_AXIS]; > > u8 samples[CROS_EC_SAMPLE_SIZE]; >