From: Jonathan Cameron <jic23@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: bleung@chromium.org, enric.balletbo@collabora.com,
groeck@chromium.org, fabien.lahoudere@collabora.com,
dianders@chromium.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/4] iio: cros_ec_accel_legacy: Fix incorrect channel setting
Date: Sat, 27 Jul 2019 23:06:13 +0100 [thread overview]
Message-ID: <20190727230613.67333b28@archlinux> (raw)
In-Reply-To: <20190715231454.189459-3-gwendal@chromium.org>
On Mon, 15 Jul 2019 16:14:52 -0700
Gwendal Grignou <gwendal@chromium.org> wrote:
> INFO_SCALE is set both for each channel and all channels.
> iio is using all channel setting, so the error was not user visible.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/accel/cros_ec_accel_legacy.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/accel/cros_ec_accel_legacy.c b/drivers/iio/accel/cros_ec_accel_legacy.c
> index 46bb2e421bb9..ad19d9c716f4 100644
> --- a/drivers/iio/accel/cros_ec_accel_legacy.c
> +++ b/drivers/iio/accel/cros_ec_accel_legacy.c
> @@ -319,7 +319,6 @@ static const struct iio_chan_spec_ext_info cros_ec_accel_legacy_ext_info[] = {
> .modified = 1, \
> .info_mask_separate = \
> BIT(IIO_CHAN_INFO_RAW) | \
> - BIT(IIO_CHAN_INFO_SCALE) | \
> BIT(IIO_CHAN_INFO_CALIBBIAS), \
> .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SCALE), \
> .ext_info = cros_ec_accel_legacy_ext_info, \
next prev parent reply other threads:[~2019-07-27 22:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 23:14 [PATCH v6 0/4] Support accelerometers for veyron_minnie Gwendal Grignou
2019-07-15 23:14 ` [PATCH v6 1/4] iio: cros_ec: Add sign vector in core for backward compatibility Gwendal Grignou
2019-07-27 22:00 ` Jonathan Cameron
2019-07-15 23:14 ` [PATCH v6 2/4] iio: cros_ec_accel_legacy: Fix incorrect channel setting Gwendal Grignou
2019-07-27 22:06 ` Jonathan Cameron [this message]
2019-07-15 23:14 ` [PATCH v6 3/4] iio: cros_ec_accel_legacy: Use cros_ec_sensors_core Gwendal Grignou
2019-07-16 8:46 ` Enric Balletbo i Serra
2019-07-27 22:07 ` Jonathan Cameron
2019-07-15 23:14 ` [PATCH v6 4/4] iio: cros_ec_accel_legacy: Add support for veyron-minnie Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190727230613.67333b28@archlinux \
--to=jic23@kernel.org \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=fabien.lahoudere@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).