From: Jonathan Cameron <jic23@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: accel: kxcjk1013: Improve comments on KIOX010A and KIOX020A ACPI ids
Date: Sun, 18 Aug 2019 18:51:39 +0100 [thread overview]
Message-ID: <20190818185139.7def1a21@archlinux> (raw)
In-Reply-To: <20190818112306.21236-1-hdegoede@redhat.com>
On Sun, 18 Aug 2019 13:23:06 +0200
Hans de Goede <hdegoede@redhat.com> wrote:
> The KIOX010A and KIOX020A ACPI ids go hand in hand, they are used in
> yoga style 2-in-1s, with KIOX010A indicating the KXCJ91008 sensor in the
> display of the 2-in-1 and KIOX020A indicating the KXCJ91008 sensor in the
> base.
>
> Improve the existing comment on the "KIOX010A" kx_acpi_match table entry
> to make clear we are talking about a yoga-style (360 degree hinges) device
> here and add a similar comment to the "KIOX020A" entry.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied to the togreg branch of iio.git and pushed out as testing to be
ignored by the autobuilders.
Thanks,
Jonathan
> ---
> drivers/iio/accel/kxcjk-1013.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 6645771aa349..fee535d6e45b 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1486,8 +1486,8 @@ static const struct acpi_device_id kx_acpi_match[] = {
> {"KIOX0008", KXCJ91008},
> {"KIOX0009", KXTJ21009},
> {"KIOX000A", KXCJ91008},
> - {"KIOX010A", KXCJ91008}, /* KXCJ91008 inside the display of a 2-in-1 */
> - {"KIOX020A", KXCJ91008},
> + {"KIOX010A", KXCJ91008}, /* KXCJ91008 in the display of a yoga 2-in-1 */
> + {"KIOX020A", KXCJ91008}, /* KXCJ91008 in the base of a yoga 2-in-1 */
> {"KXTJ1009", KXTJ21009},
> {"KXJ2109", KXTJ21009},
> {"SMO8500", KXCJ91008},
prev parent reply other threads:[~2019-08-18 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 11:23 [PATCH] iio: accel: kxcjk1013: Improve comments on KIOX010A and KIOX020A ACPI ids Hans de Goede
2019-08-18 17:51 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190818185139.7def1a21@archlinux \
--to=jic23@kernel.org \
--cc=hdegoede@redhat.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).