From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BCA2C3A589 for ; Sun, 18 Aug 2019 17:55:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA6B92183E for ; Sun, 18 Aug 2019 17:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566150951; bh=81ed9RBM09C9vmEgmyh5QD5J7tn2TnHkzuCZiVnKQNw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=YhbZcygw8eIfzLTXgyQgzmMk3BJ0Sw75J7ABCn//NBbIM4VFQ7/euaG7fjXro8g1l jj6J8gBrVzg4KKm3o7E7xtu5M3IHf7pSBUAaUcTA44sUc6Ezz7GFUiPrNu0hsAPFYT Y6GvBydxxpOQNm7974J6dXBoaymPdZCxJ9i7mbVE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbfHRRzu (ORCPT ); Sun, 18 Aug 2019 13:55:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:48682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726747AbfHRRzu (ORCPT ); Sun, 18 Aug 2019 13:55:50 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B6C220B7C; Sun, 18 Aug 2019 17:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566150949; bh=81ed9RBM09C9vmEgmyh5QD5J7tn2TnHkzuCZiVnKQNw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=baXrZ81Nj/oC6AstnQfLU4ymhv9m478hZqX7mJHqFJ8Q1UzpdggNWlQaRpitHULuU riLpw5ycrtPNQnUjXpubYNkzquyVSISXhZAD66pgMg+Pt/vEt5sC/0eac7P256n+qc IA4+d5q4eNMTnVWWtIQ5TXzFIOmSjpCR44Uin3YU= Date: Sun, 18 Aug 2019 18:55:44 +0100 From: Jonathan Cameron To: "Ardelean, Alexandru" Cc: "Popa, Stefan Serban" , "linux-iio@vger.kernel.org" , "colin.king@canonical.com" , "Hennerich, Michael" , "lars@metafoo.de" , "knaack.h@gmx.de" , "pmeerw@pmeerw.net" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] iio: dac: ad5380: fix incorrect assignment to val Message-ID: <20190818185544.66c32add@archlinux> In-Reply-To: <876a4d5190828619f75365863cc6bf2cfea4ffea.camel@analog.com> References: <20190815115846.21800-1-colin.king@canonical.com> <876a4d5190828619f75365863cc6bf2cfea4ffea.camel@analog.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 16 Aug 2019 06:16:26 +0000 "Ardelean, Alexandru" wrote: > On Thu, 2019-08-15 at 12:58 +0100, Colin King wrote: > > [External] > > > > Reviewed-by: Alexandru Ardelean Applied to the fixes-togreg branch of iio.git. Thanks, Jonathan > > > From: Colin Ian King > > > > Currently the pointer val is being incorrectly incremented > > instead of the value pointed to by val. Fix this by adding > > in the missing * indirection operator. > > > > Addresses-Coverity: ("Unused value") > > Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver") > > Signed-off-by: Colin Ian King > > --- > > drivers/iio/dac/ad5380.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c > > index 4335214800d2..2ebe08326048 100644 > > --- a/drivers/iio/dac/ad5380.c > > +++ b/drivers/iio/dac/ad5380.c > > @@ -220,7 +220,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev, > > if (ret) > > return ret; > > *val >>= chan->scan_type.shift; > > - val -= (1 << chan->scan_type.realbits) / 2; > > + *val -= (1 << chan->scan_type.realbits) / 2; > > return IIO_VAL_INT; > > case IIO_CHAN_INFO_SCALE: > > *val = 2 * st->vref;