From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B03C3A59E for ; Wed, 21 Aug 2019 20:24:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9A5B2339E for ; Wed, 21 Aug 2019 20:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566419079; bh=3HyrRsHJZj2Gsrfh1tG8TODae9gNZTTtjlZiEFcaATQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ch88uCmJUDRzirdLvwitC/69lnAFveIZn/avXhMH79isbOMKYVhdJ2Qm8KIhr+Vtc pyS5ece6K04NMLgIfeW/g+y0AEeR8uB1S5RdBduXzIwxyfL5xftTjIank1Kwyz1Z0X XPvveDsFOGbCh1IOSRmiTy3HndwLWqxH2F9kKr5M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728836AbfHUUYf (ORCPT ); Wed, 21 Aug 2019 16:24:35 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:36340 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727014AbfHUUYd (ORCPT ); Wed, 21 Aug 2019 16:24:33 -0400 Received: by mail-ot1-f67.google.com with SMTP id k18so3334139otr.3; Wed, 21 Aug 2019 13:24:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=VlPveHWnHmyI+1GWA+q9rNyELGwhQs00BTq/EJHSID0=; b=ni4lVT4FXf7a3gaNnKoy44qRhrBIuzc5Psel/vKsrTfjm5t+15L52sz8aOZz9nCevU ItrRP9FCsun0xc04UamKJUmZtn6GBvMGEkHQZMx0y2WsmkwfMsk7qtpoHaC8tN+fCl68 okm2ETenSkH99i8Cp9eFRfu6Tbr/ipiljgkYXc9XxqujGlnMARikQLIdZdgzAUaqZTeZ 2ZGUWhgBnt9lBHwzPa7wNbjSKHvkNYrikNedZ8Ivd0BcV672BfYy3YmsG94xB0qNBIsy MD3pYE4WawrbmYIWQ0iZOEeB9Jl8WwQM57NCWFBNSBt5bUwvX0Kdt6moXSzkXSlES9DQ 8uiQ== X-Gm-Message-State: APjAAAUWd2Aff4ep9JQBDFZr/hTP7OtlXdKqTfrSxg8rmKT6MRHrOSl5 ePUQ+i9eDdA9pLND6H23xg== X-Google-Smtp-Source: APXvYqxsyxl0+BA8DnarEBxAjNEfvqSpPFn4omaSMp55d98bPbvFplH4u83uwrmvf7zORhjwacx89w== X-Received: by 2002:a05:6830:1151:: with SMTP id x17mr26546521otq.270.1566419072002; Wed, 21 Aug 2019 13:24:32 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id a21sm3387232oie.9.2019.08.21.13.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2019 13:24:31 -0700 (PDT) Date: Wed, 21 Aug 2019 15:24:30 -0500 From: Rob Herring To: Beniamin Bia Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, paulmck@linux.ibm.com, mchehab+samsung@kernel.org, linus.walleij@linaro.org, nicolas.ferre@microchip.com, biabeniamin@outlook.com Subject: Re: [PATCH v2 3/4] dt-bindings: iio: adc: Migrate AD7606 documentation to yaml Message-ID: <20190821202430.GA16419@bogus> References: <20190807133137.11185-1-beniamin.bia@analog.com> <20190807133137.11185-3-beniamin.bia@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190807133137.11185-3-beniamin.bia@analog.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, Aug 07, 2019 at 04:31:36PM +0300, Beniamin Bia wrote: > The documentation for ad7606 was migrated to yaml. > > Signed-off-by: Beniamin Bia > --- > Changes in v2: > -old txt file was deleted > > .../bindings/iio/adc/adi,ad7606.txt | 66 --------- > .../bindings/iio/adc/adi,ad7606.yaml | 134 ++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 135 insertions(+), 67 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt > deleted file mode 100644 > index d8652460198e..000000000000 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt > +++ /dev/null > @@ -1,66 +0,0 @@ > -Analog Devices AD7606 Simultaneous Sampling ADC > - > -Required properties for the AD7606: > - > -- compatible: Must be one of > - * "adi,ad7605-4" > - * "adi,ad7606-8" > - * "adi,ad7606-6" > - * "adi,ad7606-4" > - * "adi,ad7616" > -- reg: SPI chip select number for the device > -- spi-max-frequency: Max SPI frequency to use > - see: Documentation/devicetree/bindings/spi/spi-bus.txt > -- spi-cpha: See Documentation/devicetree/bindings/spi/spi-bus.txt > -- avcc-supply: phandle to the Avcc power supply > -- interrupts: IRQ line for the ADC > - see: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > -- adi,conversion-start-gpios: must be the device tree identifier of the CONVST pin. > - This logic input is used to initiate conversions on the analog > - input channels. As the line is active high, it should be marked > - GPIO_ACTIVE_HIGH. > - > -Optional properties: > - > -- reset-gpios: must be the device tree identifier of the RESET pin. If specified, > - it will be asserted during driver probe. As the line is active high, > - it should be marked GPIO_ACTIVE_HIGH. > -- standby-gpios: must be the device tree identifier of the STBY pin. This pin is used > - to place the AD7606 into one of two power-down modes, Standby mode or > - Shutdown mode. As the line is active low, it should be marked > - GPIO_ACTIVE_LOW. > -- adi,first-data-gpios: must be the device tree identifier of the FRSTDATA pin. > - The FRSTDATA output indicates when the first channel, V1, is > - being read back on either the parallel, byte or serial interface. > - As the line is active high, it should be marked GPIO_ACTIVE_HIGH. > -- adi,range-gpios: must be the device tree identifier of the RANGE pin. The polarity on > - this pin determines the input range of the analog input channels. If > - this pin is tied to a logic high, the analog input range is ±10V for > - all channels. If this pin is tied to a logic low, the analog input range > - is ±5V for all channels. As the line is active high, it should be marked > - GPIO_ACTIVE_HIGH. > -- adi,oversampling-ratio-gpios: must be the device tree identifier of the over-sampling > - mode pins. As the line is active high, it should be marked > - GPIO_ACTIVE_HIGH. > - > -Example: > - > - adc@0 { > - compatible = "adi,ad7606-8"; > - reg = <0>; > - spi-max-frequency = <1000000>; > - spi-cpol; > - > - avcc-supply = <&adc_vref>; > - > - interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > - interrupt-parent = <&gpio>; > - > - adi,conversion-start-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>; > - reset-gpios = <&gpio 27 GPIO_ACTIVE_HIGH>; > - adi,first-data-gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > - adi,oversampling-ratio-gpios = <&gpio 18 GPIO_ACTIVE_HIGH > - &gpio 23 GPIO_ACTIVE_HIGH > - &gpio 26 GPIO_ACTIVE_HIGH>; > - standby-gpios = <&gpio 24 GPIO_ACTIVE_LOW>; > - }; > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml > new file mode 100644 > index 000000000000..509dbe9c84d2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml > @@ -0,0 +1,134 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD7606 Simultaneous Sampling ADC > + > +maintainers: > + - Beniamin Bia > + - Stefan Popa > + > +description: | > + Analog Devices AD7606 Simultaneous Sampling ADC > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7606_7606-6_7606-4.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7616.pdf > + > +properties: > + compatible: > + enum: > + - adi,ad7605-4 > + - adi,ad7606-8 > + - adi,ad7606-6 > + - adi,ad7606-4 > + - adi,ad7616 > + > + reg: > + maxItems: 1 > + > + spi-cpha: true > + > + avcc-supply: > + description: > + Phandle to the Avcc power supply > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + adi,conversion-start-gpios: > + description: > + Must be the device tree identifier of the CONVST pin. > + This logic input is used to initiate conversions on the analog > + input channels. As the line is active high, it should be marked > + GPIO_ACTIVE_HIGH. > + maxItems: 1 > + > + reset-gpios: > + description: > + Must be the device tree identifier of the RESET pin. If specified, > + it will be asserted during driver probe. As the line is active high, > + it should be marked GPIO_ACTIVE_HIGH. > + maxItems: 1 > + > + standby-gpios: > + description: > + Must be the device tree identifier of the STBY pin. This pin is used > + to place the AD7606 into one of two power-down modes, Standby mode or > + Shutdown mode. As the line is active low, it should be marked > + GPIO_ACTIVE_LOW. > + maxItems: 1 > + > + adi,first-data-gpios: > + description: > + Must be the device tree identifier of the FRSTDATA pin. > + The FRSTDATA output indicates when the first channel, V1, is > + being read back on either the parallel, byte or serial interface. > + As the line is active high, it should be marked GPIO_ACTIVE_HIGH. > + maxItems: 1 > + > + adi,range-gpios: > + description: > + Must be the device tree identifier of the RANGE pin. The polarity on > + this pin determines the input range of the analog input channels. If > + this pin is tied to a logic high, the analog input range is ±10V for > + all channels. If this pin is tied to a logic low, the analog input range > + is ±5V for all channels. As the line is active high, it should be marked > + GPIO_ACTIVE_HIGH. > + maxItems: 1 > + > + adi,oversampling-ratio-gpios: > + description: > + Must be the device tree identifier of the over-sampling > + mode pins. As the line is active high, it should be marked > + GPIO_ACTIVE_HIGH. > + maxItems: 1 > + > + adi,sw-mode: > + description: > + Software mode of operation, so far available only for ad7616. > + It is enabled when all three oversampling mode pins are connected to > + high level. The device is configured by the corresponding registers. If the > + adi,oversampling-ratio-gpios property is defined, then the driver will set the > + oversampling gpios to high. Otherwise, it is assumed that the pins are hardwired > + to VDD. > + maxItems: 1 Drop this. Doesn't make sense as a boolean can't be an array. I have a meta-schema check for this pending. With that, Reviewed-by: Rob Herring