From: Jonathan Cameron <jic23@kernel.org>
To: Pascal Bouwmann <bouwmann@tau-tec.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: Linux Kernel: Bug in the bmc150 driver
Date: Mon, 26 Aug 2019 09:22:25 +0100 [thread overview]
Message-ID: <20190826092225.73a459a2@archlinux> (raw)
In-Reply-To: <87be60bb-895c-b6a0-9e04-ffeda1f7fb28@tau-tec.de>
On Mon, 26 Aug 2019 06:58:26 +0200
Pascal Bouwmann <bouwmann@tau-tec.de> wrote:
> Dear Mr. Cameron,
>
> in the bmc150 driver I probably found a mistake:
> In the datasheets of the supported devices it is written that the
> central temperature is 23°C (see links below).
Hi. This is curious.
>
> BMC150:
> https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMC150-DS000.pdf,
> page 27
Look at page 72 where the register is defined and there the 0 value is specified as 24.
I haven't checked the others but at a quick glance at this one case it would seem the
data sheets are internally inconsistent.
I'm inclined to go with the version provided with the register definition rather than
the descriptive text, but obviously the best option would be to get a clarification
on this from Bosch.
Thanks,
Jonathan
> BMI055:
> https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMI055-DS000.pdf,
> page 23
> BMA255:
> https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA255-DS004.pdf,
> page 19
> BMA250E:
> https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA250E-DS004.pdf,
> page 19
> BMA222E:
> https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA222E-DS004.pdf,
> page 19
> BMA280:
> https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA280-DS000.pdf,
> page 19
>
> In the driver drivers/iio/accel/bmc150-accel-core.c the constant
> BMC150_ACCEL_TEMP_CENTER_VAL should therefore be 23 instead of 24.
> This constant is defined in line
> 120:https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/drivers/iio/accel/bmc150-accel-core.c?h=v5.3-rc6
>
parent reply other threads:[~2019-08-26 8:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <87be60bb-895c-b6a0-9e04-ffeda1f7fb28@tau-tec.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826092225.73a459a2@archlinux \
--to=jic23@kernel.org \
--cc=bouwmann@tau-tec.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox