From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92FB4C3A5A5 for ; Tue, 3 Sep 2019 12:37:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 750BA206B8 for ; Tue, 3 Sep 2019 12:37:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727667AbfICMhX (ORCPT ); Tue, 3 Sep 2019 08:37:23 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6190 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728994AbfICMhW (ORCPT ); Tue, 3 Sep 2019 08:37:22 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 1A98DAE6AA0E08BB86B1; Tue, 3 Sep 2019 20:37:20 +0800 (CST) Received: from localhost (10.202.226.61) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Tue, 3 Sep 2019 20:37:18 +0800 Date: Tue, 3 Sep 2019 13:37:08 +0100 From: Jonathan Cameron To: Martin Kepplinger CC: Jonathan Cameron , Lorenzo Bianconi , Martin Kepplinger , , , Subject: Re: [BUG] Re: [PATCH] iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1 Message-ID: <20190903133708.00002f22@huawei.com> In-Reply-To: References: <20190827210857.718d7f9b@archlinux> <37cb0888-50b6-40d2-1289-a78499a90b7c@puri.sm> <20190829083714.GA2880@localhost.localdomain> <20190830072354.GA5910@localhost.localdomain> <531903f2-a4df-87a8-6417-68463261b859@puri.sm> <20190831093224.GA5393@lore-desk-wlan.lan> <20190901155023.249271e1@archlinux> Organization: Huawei X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.61] X-CFilter-Loop: Reflected Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 3 Sep 2019 07:22:20 +0200 Martin Kepplinger wrote: > On 01.09.19 16:50, Jonathan Cameron wrote: > > [...] > > > > > Rather than messing around with a pull request that has already gone > > to Greg, I'm going to leave this as it is for now. > > > > The trace doesn't make a lot of sense to me and whilst a bit messy (as fixed > > up by Lorenzo's follow up) I can't see why things would crash. > > > > So needs debugging and that isn't a problem given we are only looking > > at putting this support into rc1. Not ideal, but there is time > > to work out what is wrong and fix it up! > > > > Thanks, > > > > Jonathan > > > > for the record, I found the problem I've had here. It's been introduced > with the DEV_NAME change and I sent a fix (and question): > > https://lore.kernel.org/linux-iio/20190903051802.22716-1-martin.kepplinger@puri.sm/T/#u > Doh. This one is entirely my fault as I messed up that last minute edit :( Greg, this bug is in my outstanding pull request. If you would prefer to pick it from lore and add my Acked-by that's great. If not I can send this after rc1. Thanks, Jonathan