From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
lorenzo.bianconi83@gmail.com, denis.ciocca@st.com,
mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com
Subject: Re: [PATCH v3 3/6] iio: imu: st_lsm6dsx: add wakeup-source option
Date: Wed, 4 Sep 2019 19:27:13 +0200 [thread overview]
Message-ID: <20190904172713.GD2058@localhost.localdomain> (raw)
In-Reply-To: <20190904091732.112281-3-sean@geanix.com>
[-- Attachment #1: Type: text/plain, Size: 2237 bytes --]
On Sep 04, Sean Nyekjaer wrote:
> This add ways for the SoC to wake from accelerometer wake events.
>
> In the suspend function we skip disabling the sensor if wakeup-source
> and events are activated.
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
> Changes since v1:
> * none, as the call to st_lsm6dsx_flush_fifo will put the fifo in
> bypass mode.
>
> Changes since v2:
> * Removed unnecessary brackets
> * Move enable_irq to after the enable mask
>
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index d4d6ba934b6d..bb72800bf99b 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -1754,6 +1754,10 @@ int st_lsm6dsx_probe(struct device *dev, int irq, int hw_id,
> return err;
> }
>
> + if (dev->of_node)
> + if (of_property_read_bool(dev->of_node, "wakeup-source"))
> + device_init_wakeup(dev, true);
if (dev->of_node &&
of_property_read_bool(dev->of_node, "wakeup-source"))
device_init_wakeup(dev, true);
I guess it is more readable in this way, isn't it?
> +
> return 0;
> }
> EXPORT_SYMBOL(st_lsm6dsx_probe);
> @@ -1772,6 +1776,12 @@ static int __maybe_unused st_lsm6dsx_suspend(struct device *dev)
> if (!(hw->enable_mask & BIT(sensor->id)))
> continue;
>
> + if (device_may_wakeup(dev) && i == ST_LSM6DSX_ID_ACC) {
> + /* Enable wake from IRQ */
> + enable_irq_wake(hw->irq);
> + continue;
> + }
> +
> if (sensor->id == ST_LSM6DSX_ID_EXT0 ||
> sensor->id == ST_LSM6DSX_ID_EXT1 ||
> sensor->id == ST_LSM6DSX_ID_EXT2)
> @@ -1804,6 +1814,11 @@ static int __maybe_unused st_lsm6dsx_resume(struct device *dev)
> if (!(hw->suspend_mask & BIT(sensor->id)))
> continue;
>
> + if (device_may_wakeup(dev) && i == ST_LSM6DSX_ID_ACC) {
> + disable_irq_wake(hw->irq);
> + continue;
> + }
> +
> if (sensor->id == ST_LSM6DSX_ID_EXT0 ||
> sensor->id == ST_LSM6DSX_ID_EXT1 ||
> sensor->id == ST_LSM6DSX_ID_EXT2)
> --
> 2.23.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-09-04 17:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 9:17 [PATCH v3 1/6] iio: imu: st_lsm6dsx: move interrupt thread to core Sean Nyekjaer
2019-09-04 9:17 ` [PATCH v3 2/6] iio: imu: st_lsm6dsx: add motion events Sean Nyekjaer
2019-09-04 17:24 ` Lorenzo Bianconi
2019-09-05 5:29 ` Sean Nyekjaer
2019-09-04 9:17 ` [PATCH v3 3/6] iio: imu: st_lsm6dsx: add wakeup-source option Sean Nyekjaer
2019-09-04 17:27 ` Lorenzo Bianconi [this message]
2019-09-04 9:17 ` [PATCH v3 4/6] iio: imu: st_lsm6dsx: always enter interrupt thread Sean Nyekjaer
2019-09-05 6:34 ` Lorenzo Bianconi
2019-09-05 6:37 ` Sean Nyekjaer
2019-09-05 6:47 ` Lorenzo Bianconi
2019-09-04 9:17 ` [PATCH v3 5/6] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Sean Nyekjaer
2019-09-05 6:39 ` Lorenzo Bianconi
2019-09-05 7:01 ` Sean Nyekjaer
2019-09-05 7:07 ` Lorenzo Bianconi
2019-09-04 9:17 ` [PATCH v3 6/6] iio: imu: st_lsm6dsx: prohibit the use of events and buffered reads simultaneously Sean Nyekjaer
2019-09-04 17:11 ` [PATCH v3 1/6] iio: imu: st_lsm6dsx: move interrupt thread to core Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904172713.GD2058@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=armando.visconti@st.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=mario.tesi@st.com \
--cc=martin@geanix.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox