Re: [PATCH v1 1/1] iio: fix center temperature of bmc150-accel-core

Jonathan Cameron
2019-09-08T12:14:08Z

On Thu, 29 Aug 2019 07:29:41 +0200
Pascal Bouwmann <bouwmann@tau-tec.de> wrote:

> The center temperature of the supported devices stored in the constant
> BMC150_ACCEL_TEMP_CENTER_VAL is not 24 degrees but 23 degrees.
>
> Signed-off-by: Pascal Bouwmann <bouwmann@tau-tec.de>

Your patch is corrupted, but I've manually applied it.

I haven't marked it for stable because I worry a little that this will give
people unexpected changes in long term trends. Better they see that only
on a major kernel version upgrade.

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
> In the datasheet of the BMC150 device the center temperature is given
> wrongly.
> See https://community.bosch-sensortec.com/t5/MEMS-sensors-forum/
> center-temperature-of-bmc150-device/td-p/9328
>
> diff --git a/drivers/iio/accel/bmc150-accel-core.c
> b/drivers/iio/accel/bmc150-accel-core.c
> index 807299dd45eb..7e86a5b7ec4e 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -125,7 +125,7 @@
>  #define BMC150_ACCEL_SLEEP_1_SEC        0x0F
>
>  #define BMC150_ACCEL_REG_TEMP            0x08
> -#define BMC150_ACCEL_TEMP_CENTER_VAL        24
> +#define BMC150_ACCEL_TEMP_CENTER_VAL        23
>
>  #define BMC150_ACCEL_AXIS_TO_REG(axis)    (BMC150_ACCEL_REG_XOUT_L +
> (axis * 2))
>  #define BMC150_AUTO_SUSPEND_DELAY_MS        2000
>