Re: [PATCH v2 1/2] dt-bindings: iio: imu: add fxos8700 imu binding

Rob Herring
2019-10-10T13:23:56Z

On Wed, Oct 9, 2019 at 8:25 PM Robert Jones <rjones@gateworks.com> wrote:
>
> This adds documentation for the Freescale FXOS8700 Inertial Measurement Unit
> device-tree bindings.
>
> Signed-off-by: Robert Jones <rjones@gateworks.com>
> ---
> .../devicetree/bindings/iio/imu/fxos8700.yaml | 54 ++++++++++++++++++++++

Follow the compatible string name, so fsl,fxos8700.yaml.

> 1 file changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/imu/fxos8700.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/fxos8700.yaml b/Documentation/devicetree/bindings/iio/imu/fxos8700.yaml
> new file mode 100644
> index 0000000..f0dbf4b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/fxos8700.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/imu/fxos8700.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale FXOS8700 Inertial Measurement Unit
> +
> +maintainers:
> + - Robert Jones <rjones@gateworks.com>
> +
> +description: |
> + Accelerometer and magnetometer combo device with an i2c interface.

Also has a SPI interface.

> + https://www.nxp.com/products/sensors/motion-sensors/6-axis/digital-motion-sensor-3d-accelerometer-2g-4g-8g-plus-3d-magnetometer:FXOS8700CQ
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,fxos8700

For a new binding, shouldn't this be nxp instead of fsl?

> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-names:
> + maxItems: 1

'const: INT1' instead. However, having '-names' doesn't really buy
much when there is only 1 entry, so I'd just drop it.

But then I read the datasheet and there are 2 interrupts, so you need
to describe 2 interrupts.

> +
> + drive-open-drain:
> + maxItems: 1

Should be boolean.

> +
> + spi-max-frequency:
> + maxItems: 1

spi-max-frequency is not an array. You should define the maximum for it.

> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fxos8700@1e {
> + compatible = "fsl,fxos8700";
> + reg = <0x1e>;
> +
> + interrupt-parent = <&gpio2>;
> + interrupts = <7 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "INT1";
> + };
> + };
> --
> 2.9.2
>