From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10928C47404 for ; Sat, 5 Oct 2019 12:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9C84222CE for ; Sat, 5 Oct 2019 12:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570278612; bh=r2fd8y2E93hYu8OVo5Fp87oBQdhWfOgQx8bj5sFr+04=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=FTum0JjU+6pXQYpDXtj9rkqxpbDGMmQKMfCBtg/qD8pRwQFzBtAbPa4LRKI8om6dh AIWHkwWLp9w6F09Pr0q7qU0XR2pse3OQc/ykuQ15wTH4Qczct9hV92ItBbk16BoZee BKDPavRrGeSVT8AiA/K3p0c46uKsYntr10L4SLv0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728220AbfJEMaM (ORCPT ); Sat, 5 Oct 2019 08:30:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:41978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbfJEMaM (ORCPT ); Sat, 5 Oct 2019 08:30:12 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D852C222CB; Sat, 5 Oct 2019 12:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570278611; bh=r2fd8y2E93hYu8OVo5Fp87oBQdhWfOgQx8bj5sFr+04=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=noNGsc13R1P8TRZEBzpPcH/dGCGaIEu8kvQgyPp1k/wz9330dvZConRFj80uNVuYq nm9dgRdv0pQkcmzlBtxwiP1on7Jyzbtutr0MLMf1Q3qa7ZtZAcuCITRd4YsDu9qlpX 1uqrE9hqj5B72EaD97Oj0f0dHLmTr/tD+KU8qQRg= Date: Sat, 5 Oct 2019 13:30:06 +0100 From: Jonathan Cameron To: Angus Ainslie Cc: Marco Felsch , knaack.h@gmx.de, lars@metafoo.de, tomas@novotny.cz, linux-iio@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 2/2] iio: light: add missing vcnl4040 of_compatible Message-ID: <20191005133006.4fc6c0a5@archlinux> In-Reply-To: References: <20190917145637.22605-1-m.felsch@pengutronix.de> <20190917145637.22605-2-m.felsch@pengutronix.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 18 Sep 2019 07:47:31 -0700 Angus Ainslie wrote: > On 2019-09-17 07:56, Marco Felsch wrote: > > Commit 5a441aade5b3 ("iio: light: vcnl4000 add support for the VCNL4040 > > proximity and light sensor") added the support for the vcnl4040 but > > forgot to add the of_compatible. Fix this by adding it now. > > > > Signed-off-by: Marco Felsch > > Reviewed-by: Angus Ainslie (Purism) angus@akkea.ca I turned the above note on what missed this into a fixes tag and marked it for stable. It's no a particularly critical fix, but it is fairly trivial and very unlikely to have side effects so lets get it tidied up everywhere. Thanks, Jonathan > > > --- > > drivers/iio/light/vcnl4000.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/iio/light/vcnl4000.c > > b/drivers/iio/light/vcnl4000.c > > index f522cb863e8c..16dacea9eadf 100644 > > --- a/drivers/iio/light/vcnl4000.c > > +++ b/drivers/iio/light/vcnl4000.c > > @@ -408,6 +408,10 @@ static const struct of_device_id > > vcnl_4000_of_match[] = { > > .compatible = "vishay,vcnl4020", > > .data = (void *)VCNL4010, > > }, > > + { > > + .compatible = "vishay,vcnl4040", > > + .data = (void *)VCNL4040, > > + }, > > { > > .compatible = "vishay,vcnl4200", > > .data = (void *)VCNL4200,