From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896C3C4360C for ; Sat, 12 Oct 2019 11:34:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55A8721A4A for ; Sat, 12 Oct 2019 11:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570880069; bh=P3Tij61XBPpQrF/fHtKD1G6EVze0k7Ta/jku+94+dsY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Ce5hpdHu/ELU2aGvpoEO2bW9ycu0cbn3IavjtbUCNdsM7U0uVkRionnIvlUW0ZS0X WmTGycPRs42tvtzrA9VlTfmq7MPPBGPyiUkz6Ah6YKjBlyBXshyAA2CIi8Glv7bvK5 0ojJcIPKfLImLH7D8cBqB/9xRAMgHv0KxRiPUpBY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727423AbfJLLe2 (ORCPT ); Sat, 12 Oct 2019 07:34:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:41562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbfJLLe2 (ORCPT ); Sat, 12 Oct 2019 07:34:28 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C56A12089C; Sat, 12 Oct 2019 11:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570880067; bh=P3Tij61XBPpQrF/fHtKD1G6EVze0k7Ta/jku+94+dsY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Hp1bxx5KTXVLndUuI3vBrTfCNBMItxJoMOqbGOH6udQegXjQwWroniPz4bMLgNZxh ju7292+08axbKa+J+NMtAzVNMCiSyOZPqpnfa6UnvOb1mp0pR2p4/aBs56LcN5zmLJ zaqwvmywRX/BDwnbd9CPi9nANxzma1+8OdyYxdUI= Date: Sat, 12 Oct 2019 12:28:10 +0100 From: Jonathan Cameron To: Miquel Raynal Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH v4 3/8] iio: adc: max1027: Reset the device at probe time Message-ID: <20191012122810.5330fd7f@archlinux> In-Reply-To: <20191011144347.19146-4-miquel.raynal@bootlin.com> References: <20191011144347.19146-1-miquel.raynal@bootlin.com> <20191011144347.19146-4-miquel.raynal@bootlin.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 11 Oct 2019 16:43:42 +0200 Miquel Raynal wrote: > All the registers are configured by the driver, let's reset the chip > at probe time, avoiding any conflict with a possible earlier > configuration. > > Signed-off-by: Miquel Raynal Applied. Thanks, Jonathan > --- > drivers/iio/adc/max1027.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c > index 823223b77a70..f9b473ee6711 100644 > --- a/drivers/iio/adc/max1027.c > +++ b/drivers/iio/adc/max1027.c > @@ -466,6 +466,14 @@ static int max1027_probe(struct spi_device *spi) > } > } > > + /* Internal reset */ > + st->reg = MAX1027_RST_REG; > + ret = spi_write(st->spi, &st->reg, 1); > + if (ret < 0) { > + dev_err(&indio_dev->dev, "Failed to reset the ADC\n"); > + return ret; > + } > + > /* Disable averaging */ > st->reg = MAX1027_AVG_REG; > ret = spi_write(st->spi, &st->reg, 1);