From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE06C4360C for ; Sat, 12 Oct 2019 15:28:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B935B2089C for ; Sat, 12 Oct 2019 15:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570894126; bh=QR75l94B390tj5GSr/6LDGfis+il3Eu83Dc2xges7Ls=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HC0BAvymZ58ifX6RJHLUvcy/0wosksRSgcDE2fuTP+ux1DlTdMn760mCwrbxoV32x d/xEJ3vq0RMIqZU/db9AbgUEx99apIh9OgLJht6pWR5gBiRNu3zPds3Jl0yfuIeFsN tAkKfnQmKPI6+TDb92AKS/iixdIckxWVBzw9c2Tg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728977AbfJLP2q (ORCPT ); Sat, 12 Oct 2019 11:28:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:42416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727642AbfJLP2q (ORCPT ); Sat, 12 Oct 2019 11:28:46 -0400 Received: from localhost (unknown [62.119.166.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A21B02089C; Sat, 12 Oct 2019 15:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570894125; bh=QR75l94B390tj5GSr/6LDGfis+il3Eu83Dc2xges7Ls=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RVHaQgJLqr079Th2JLSC3LfaSF1kev3JCn/qYiOyjacBfrYx7MQZyeGWCxsozBERD 8zmZYDTNivIkgvLkQz7ENM0KgwWEKMmwt0RpRz0GS1NcTcq+T95IBgBiDWtjy01IvN Ssxs+IU1iqDp57vGhukZSaZTwYHiPoTW9j5zxR2Y= Date: Sat, 12 Oct 2019 17:28:41 +0200 From: Greg KH To: Jonathan Cameron Cc: linux-iio@vger.kernel.org Subject: Re: [PULL v2] First set of iio new device support etc for the 5.5 cycle Message-ID: <20191012152841.GB2142233@kroah.com> References: <20191012121946.051b646f@archlinux> <20191012152744.GA2142233@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191012152744.GA2142233@kroah.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, Oct 12, 2019 at 05:27:44PM +0200, Greg KH wrote: > On Sat, Oct 12, 2019 at 12:19:46PM +0100, Jonathan Cameron wrote: > > The following changes since commit b73b93a2af3392b9b7b8ba7e818ee767499f9655: > > > > iio: adc: ad7192: Add sysfs ABI documentation (2019-09-08 10:34:49 +0100) > > > > are available in the Git repository at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-5.5a-take2 > > Better, but I see this now: > > drivers/iio/imu/adis.c: In function ‘__adis_check_status’: > drivers/iio/imu/adis.c:295:9: warning: ‘status’ may be used uninitialized in this function [-Wmaybe-uninitialized] > 295 | status &= adis->data->status_error_mask; > | ^~ > > > I'll take this, can you just send a follow-on patch for this? Also I see: drivers/iio/imu/adis16480.c: In function ‘adis16480_enable_irq’: drivers/iio/imu/adis16480.c:950:6: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] 950 | val &= ~ADIS16480_DRDY_EN_MSK; | ^~ CC [M] drivers/iio/magnetometer/hmc5843_i2c.o drivers/iio/imu/adis16480.c: In function ‘adis16480_write_raw’: drivers/iio/imu/adis16480.c:571:7: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] 571 | val &= ~enable_mask; | ^~ drivers/iio/imu/adis16480.c:557:11: note: ‘val’ was declared here 557 | uint16_t val; | ^~~ So did you really fix anything here? I'll drop this pull again. What version of gcc are you using? Might I suggest a newer one (i.e. a modern one?) thanks, greg k-h