From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68943C4360C for ; Sun, 13 Oct 2019 09:57:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 375DC206A3 for ; Sun, 13 Oct 2019 09:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570960641; bh=PTGfE6rg34JkW4EyQE873y0B+++yKeoya/IaJGIPNEo=; h=From:To:Cc:Subject:Date:List-ID:From; b=jNaVzf7XXQp7zqDe1qeQQahot5NSk2ERj6PR3/Ji5frxMZLah3UgpeF0t3a+DCNhI xoKvdyRk/n4ZAjNi+RsrJ0rP5ii1cktHL/iljYByWjEtKpt33Bpd7BFA10Uf+9SZmf ZbsTPPmKyHHlj0gLZirrf68QVtOTFtx4ACOeCKbk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728621AbfJMJ5U (ORCPT ); Sun, 13 Oct 2019 05:57:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:50768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728543AbfJMJ5U (ORCPT ); Sun, 13 Oct 2019 05:57:20 -0400 Received: from localhost.localdomain (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 514C020673; Sun, 13 Oct 2019 09:57:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570960640; bh=PTGfE6rg34JkW4EyQE873y0B+++yKeoya/IaJGIPNEo=; h=From:To:Cc:Subject:Date:From; b=rrzJiJJgo/bdDE3lK6KJB+9lgNYjuucSLyfRI3XsD9iXpTXKS0wAUta8sy2ZENaOW t/bEVU9tWdtKscAKG9czclRFBN6GdOLQ38W6NqGUISWq8gcCJc++JLAxsA8hhy3HkF 45/9mWke30pIiTKtm8uBCF8s9o86zXMBE3wXJXus= From: jic23@kernel.org To: linux-iio@vger.kernel.org Cc: Jonathan Cameron , Tomasz Duszynski Subject: [PATCH] iio: chemical: sps30: Explicity truncate constant by masking Date: Sun, 13 Oct 2019 10:55:15 +0100 Message-Id: <20191013095515.1438147-1-jic23@kernel.org> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org From: Jonathan Cameron When breaking up a constant to write to two 8 bit registers it isn't obvious to sparse that it was intentional. CHECK drivers/iio/chemical/sps30.c drivers/iio/chemical/sps30.c:120:30: warning: cast truncates bits from constant value (8004 becomes 4) So in the interests of minimising noisy warnings, let us add a mask. Signed-off-by: Jonathan Cameron Cc: Tomasz Duszynski --- drivers/iio/chemical/sps30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/chemical/sps30.c b/drivers/iio/chemical/sps30.c index edbb956e81e8..acb9f8ecbb3d 100644 --- a/drivers/iio/chemical/sps30.c +++ b/drivers/iio/chemical/sps30.c @@ -117,7 +117,7 @@ static int sps30_do_cmd(struct sps30_state *state, u16 cmd, u8 *data, int size) break; case SPS30_READ_AUTO_CLEANING_PERIOD: buf[0] = SPS30_AUTO_CLEANING_PERIOD >> 8; - buf[1] = (u8)SPS30_AUTO_CLEANING_PERIOD; + buf[1] = (u8)(SPS30_AUTO_CLEANING_PERIOD & 0xff); /* fall through */ case SPS30_READ_DATA_READY_FLAG: case SPS30_READ_DATA: -- 2.23.0