public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Philippe Schenker <philippe.schenker@toradex.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio:adc:stmpe-adc: Cleanup endian type of local variable
Date: Fri, 18 Oct 2019 19:50:23 +0100	[thread overview]
Message-ID: <20191018195023.013da2ff@archlinux> (raw)
In-Reply-To: <28f616a36507f0473aa37857fe58f3763bee4f5e.camel@toradex.com>

On Mon, 14 Oct 2019 07:50:33 +0000
Philippe Schenker <philippe.schenker@toradex.com> wrote:

> On Sun, 2019-10-13 at 10:15 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Nothing stops data being of type __be16, which fixes the warning:
> > 
> > CHECK   drivers/iio/adc/stmpe-adc.c
> > drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16
> > drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16
> > drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16
> > drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Philippe Schenker <philippe.schenker@toradex.com>  
> 
> Thanks for fixing that.
> 
> Reviewed-by: <philippe.schenker@toradex.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> 
> > ---
> >  drivers/iio/adc/stmpe-adc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c
> > index bd72727fc417..0f88048ea48f 100644
> > --- a/drivers/iio/adc/stmpe-adc.c
> > +++ b/drivers/iio/adc/stmpe-adc.c
> > @@ -175,7 +175,7 @@ static int stmpe_read_raw(struct iio_dev
> > *indio_dev,
> >  static irqreturn_t stmpe_adc_isr(int irq, void *dev_id)
> >  {
> >  	struct stmpe_adc *info = (struct stmpe_adc *)dev_id;
> > -	u16 data;
> > +	__be16 data;
> >  
> >  	if (info->channel <= STMPE_ADC_LAST_NR) {
> >  		int int_sta;  


      reply	other threads:[~2019-10-18 18:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-13  9:15 [PATCH] iio:adc:stmpe-adc: Cleanup endian type of local variable jic23
2019-10-14  7:50 ` Philippe Schenker
2019-10-18 18:50   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191018195023.013da2ff@archlinux \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=philippe.schenker@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox