Re: [PATCH v4 2/2] iio: (bma400) add driver for the BMA400

Dan Robertson
2019-10-19T01:50:21Z

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

On Thu, Oct 17, 2019 at 09:25:37PM -0700, Randy Dunlap wrote:
> On 10/17/19 8:18 PM, Dan Robertson wrote:
> > +config BMA400
> > + tristate "Bosch BMA400 3-Axis Accelerometer Driver"
> > + depends on I2C
> > + select REGMAP
> > + select BMA400_I2C if (I2C)
>
> Since BMA400 already depends on I2C, the "if (I2C)" above is
> redundant so it's not needed.

You are correct. I'll remove the depends on I2C.

> > +struct bma400_data {
> > + struct device *dev;
> > + struct mutex mutex; /* data register lock */
>
> needs #include <linux/mutex.h>

Good point.

> > +static int bma400_get_accel_scale_idx(struct bma400_data *data, int val)
> > +{
> > + int i;
> > +
> > + for (i = 1; i < ARRAY_SIZE(bma400_scale_table); i += 2) {
>
> needs #include <linux/kernel.h>
> for ARRAY_SIZE()

Thanks

Cheers,

- Dan

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]