Re: [PATCH] iio: adc: lpc18xx: use devm_platform_ioremap_resource

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 4 Nov 2019 15:19:33 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sun, 2019-10-13 at 16:32 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Avoid local boilerplate.
> > Identified by coccinelle
> > 
> > CHECK   drivers/iio/adc/lpc18xx_adc.c
> > drivers/iio/adc/lpc18xx_adc.c:137:1-10: WARNING: Use
> > devm_platform_ioremap_resource for adc -> base  
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,

Thanks,

Jonathan

> 
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Joachim Eastwood <manabian@gmail.com>
> > ---
> >  drivers/iio/adc/lpc18xx_adc.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/lpc18xx_adc.c
> > b/drivers/iio/adc/lpc18xx_adc.c
> > index e400a95f553d..4c6ac6644dc0 100644
> > --- a/drivers/iio/adc/lpc18xx_adc.c
> > +++ b/drivers/iio/adc/lpc18xx_adc.c
> > @@ -119,7 +119,6 @@ static int lpc18xx_adc_probe(struct platform_device
> > *pdev)
> >  {
> >  	struct iio_dev *indio_dev;
> >  	struct lpc18xx_adc *adc;
> > -	struct resource *res;
> >  	unsigned int clkdiv;
> >  	unsigned long rate;
> >  	int ret;
> > @@ -133,8 +132,7 @@ static int lpc18xx_adc_probe(struct platform_device
> > *pdev)
> >  	adc->dev = &pdev->dev;
> >  	mutex_init(&adc->lock);
> >  
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	adc->base = devm_ioremap_resource(&pdev->dev, res);
> > +	adc->base = devm_platform_ioremap_resource(pdev, 0);
> >  	if (IS_ERR(adc->base))
> >  		return PTR_ERR(adc->base);
> >