From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF060C43331 for ; Sat, 9 Nov 2019 12:25:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A83B121924 for ; Sat, 9 Nov 2019 12:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573302332; bh=/9GBtJ0J9S/ji+0C6CU9c8LU6xj/0h5E2B5meCZU0d0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=yEtscLMoGqFvd4FyG6ew4fERQxGJctDq4c94240eV5amoALXFpd/7Ia56XhvhqROJ rGT5AD1+A1mRHeHXeLGQkA8Le4y1XrKSh0H3jQfyBBmxTZSs7CZkRgYI5uG8M3NikI 8RSqVgqnCwyBZRYqwybtedWdvUYtdg0d7duLc01A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726492AbfKIMZc (ORCPT ); Sat, 9 Nov 2019 07:25:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:43420 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726296AbfKIMZc (ORCPT ); Sat, 9 Nov 2019 07:25:32 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C7B620659; Sat, 9 Nov 2019 12:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573302331; bh=/9GBtJ0J9S/ji+0C6CU9c8LU6xj/0h5E2B5meCZU0d0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U/7YuDXAspOA6/h3vj1YPBcq235FHYhuMv2miYOaLT6qwEG+QrUyOAOngZNccO4N2 U0s+RusulIrhCaPjqGSXpF2C4vJ7x6e4LFH8i6oERSZWdwZGW6AImfnJdu9xjjHPgr zrNXQobMsNvNEZ4HZlOuAmS4imWPJftAjdrhiRME= Date: Sat, 9 Nov 2019 12:25:26 +0000 From: Jonathan Cameron To: "Ardelean, Alexandru" Cc: "linux-iio@vger.kernel.org" , "marek.vasut+renesas@gmail.com" , "Jonathan.Cameron@huawei.com" Subject: Re: [PATCH] iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource Message-ID: <20191109122526.01a269a7@archlinux> In-Reply-To: <853e5567973d6225307d6b557ecdcca61c86e0b7.camel@analog.com> References: <20191013154832.1858884-1-jic23@kernel.org> <853e5567973d6225307d6b557ecdcca61c86e0b7.camel@analog.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 4 Nov 2019 15:17:28 +0000 "Ardelean, Alexandru" wrote: > On Sun, 2019-10-13 at 16:48 +0100, jic23@kernel.org wrote: > > From: Jonathan Cameron > > > > Avoids some local boilerplate. > > Suggested by coccinelle. > > > > CHECK drivers/iio/adc/rcar-gyroadc.c > > drivers/iio/adc/rcar-gyroadc.c:495:1-11: WARNING: Use > > devm_platform_ioremap_resource for priv -> regs > > > > Reviewed-by: Alexandru Ardelean Applied, Thanks, Jonathan > > > Signed-off-by: Jonathan Cameron > > Cc: Marek Vasut > > --- > > drivers/iio/adc/rcar-gyroadc.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar- > > gyroadc.c > > index c37f201294b2..63ce743ee7af 100644 > > --- a/drivers/iio/adc/rcar-gyroadc.c > > +++ b/drivers/iio/adc/rcar-gyroadc.c > > @@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device > > *pdev) > > struct device *dev = &pdev->dev; > > struct rcar_gyroadc *priv; > > struct iio_dev *indio_dev; > > - struct resource *mem; > > int ret; > > > > indio_dev = devm_iio_device_alloc(dev, sizeof(*priv)); > > @@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device > > *pdev) > > priv = iio_priv(indio_dev); > > priv->dev = dev; > > > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - priv->regs = devm_ioremap_resource(dev, mem); > > + priv->regs = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(priv->regs)) > > return PTR_ERR(priv->regs); > >