* [PATCH] iio: adc: spear_adc: Use devm_platform_ioremap_resource
@ 2019-10-13 15:52 jic23
2019-11-04 15:17 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 15:52 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Avoids local boilerplate doing the same thing.
Suggested by coccinelle
CHECK drivers/iio/adc/spear_adc.c
drivers/iio/adc/spear_adc.c:283:1-22: WARNING: Use devm_platform_ioremap_resource for st -> adc_base_spear6xx
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/iio/adc/spear_adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/spear_adc.c b/drivers/iio/adc/spear_adc.c
index 592b97c464da..0ad536494e8f 100644
--- a/drivers/iio/adc/spear_adc.c
+++ b/drivers/iio/adc/spear_adc.c
@@ -260,7 +260,6 @@ static int spear_adc_probe(struct platform_device *pdev)
struct device_node *np = pdev->dev.of_node;
struct device *dev = &pdev->dev;
struct spear_adc_state *st;
- struct resource *res;
struct iio_dev *indio_dev = NULL;
int ret = -ENODEV;
int irq;
@@ -279,8 +278,7 @@ static int spear_adc_probe(struct platform_device *pdev)
* (e.g. SPEAr3xx). Let's provide two register base addresses
* to support multi-arch kernels.
*/
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- st->adc_base_spear6xx = devm_ioremap_resource(&pdev->dev, res);
+ st->adc_base_spear6xx = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(st->adc_base_spear6xx))
return PTR_ERR(st->adc_base_spear6xx);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: spear_adc: Use devm_platform_ioremap_resource
2019-10-13 15:52 [PATCH] iio: adc: spear_adc: Use devm_platform_ioremap_resource jic23
@ 2019-11-04 15:17 ` Ardelean, Alexandru
2019-11-09 12:27 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2019-11-04 15:17 UTC (permalink / raw)
To: jic23@kernel.org, linux-iio@vger.kernel.org; +Cc: Jonathan.Cameron@huawei.com
On Sun, 2019-10-13 at 16:52 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Avoids local boilerplate doing the same thing.
> Suggested by coccinelle
>
> CHECK drivers/iio/adc/spear_adc.c
> drivers/iio/adc/spear_adc.c:283:1-22: WARNING: Use
> devm_platform_ioremap_resource for st -> adc_base_spear6xx
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/iio/adc/spear_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/spear_adc.c b/drivers/iio/adc/spear_adc.c
> index 592b97c464da..0ad536494e8f 100644
> --- a/drivers/iio/adc/spear_adc.c
> +++ b/drivers/iio/adc/spear_adc.c
> @@ -260,7 +260,6 @@ static int spear_adc_probe(struct platform_device
> *pdev)
> struct device_node *np = pdev->dev.of_node;
> struct device *dev = &pdev->dev;
> struct spear_adc_state *st;
> - struct resource *res;
> struct iio_dev *indio_dev = NULL;
> int ret = -ENODEV;
> int irq;
> @@ -279,8 +278,7 @@ static int spear_adc_probe(struct platform_device
> *pdev)
> * (e.g. SPEAr3xx). Let's provide two register base addresses
> * to support multi-arch kernels.
> */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - st->adc_base_spear6xx = devm_ioremap_resource(&pdev->dev, res);
> + st->adc_base_spear6xx = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(st->adc_base_spear6xx))
> return PTR_ERR(st->adc_base_spear6xx);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: spear_adc: Use devm_platform_ioremap_resource
2019-11-04 15:17 ` Ardelean, Alexandru
@ 2019-11-09 12:27 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-11-09 12:27 UTC (permalink / raw)
To: Ardelean, Alexandru
Cc: linux-iio@vger.kernel.org, Jonathan.Cameron@huawei.com
On Mon, 4 Nov 2019 15:17:47 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 16:52 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Avoids local boilerplate doing the same thing.
> > Suggested by coccinelle
> >
> > CHECK drivers/iio/adc/spear_adc.c
> > drivers/iio/adc/spear_adc.c:283:1-22: WARNING: Use
> > devm_platform_ioremap_resource for st -> adc_base_spear6xx
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,
Thanks for sanity checking all these :)
Jonathan
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> > drivers/iio/adc/spear_adc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/spear_adc.c b/drivers/iio/adc/spear_adc.c
> > index 592b97c464da..0ad536494e8f 100644
> > --- a/drivers/iio/adc/spear_adc.c
> > +++ b/drivers/iio/adc/spear_adc.c
> > @@ -260,7 +260,6 @@ static int spear_adc_probe(struct platform_device
> > *pdev)
> > struct device_node *np = pdev->dev.of_node;
> > struct device *dev = &pdev->dev;
> > struct spear_adc_state *st;
> > - struct resource *res;
> > struct iio_dev *indio_dev = NULL;
> > int ret = -ENODEV;
> > int irq;
> > @@ -279,8 +278,7 @@ static int spear_adc_probe(struct platform_device
> > *pdev)
> > * (e.g. SPEAr3xx). Let's provide two register base addresses
> > * to support multi-arch kernels.
> > */
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - st->adc_base_spear6xx = devm_ioremap_resource(&pdev->dev, res);
> > + st->adc_base_spear6xx = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(st->adc_base_spear6xx))
> > return PTR_ERR(st->adc_base_spear6xx);
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-09 12:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-13 15:52 [PATCH] iio: adc: spear_adc: Use devm_platform_ioremap_resource jic23
2019-11-04 15:17 ` Ardelean, Alexandru
2019-11-09 12:27 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).