From: Jonathan Cameron <jic23@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Stefan Popa <stefan.popa@analog.com>,
Alexandru Ardelean <alexandru.Ardelean@analog.com>,
linux-iio@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 0/3] iio: adc: add support for ltc2496
Date: Sat, 16 Nov 2019 15:31:08 +0000 [thread overview]
Message-ID: <20191116153108.578020f8@archlinux> (raw)
In-Reply-To: <20191114105159.14195-1-u.kleine-koenig@pengutronix.de>
On Thu, 14 Nov 2019 11:51:56 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Hello,
>
> this is v2 of a series sent earlier starting with Message-id:
> 20191111214025.18310-1-u.kleine-koenig@pengutronix.de and addresses the
> comments by Alexandru Ardelean. I'm a bit naughty here because I didn't
> carry out all suggestions. So I didn't use ...-spi.c and -i2c.c as file
> names, because this isn't about a single chip supporting both, but two
> different ones supporting only one bus each. So I thought ltc2496.c,
> ltc2497.c and ltc249x.c was fine.
Not using the particular naming Alex suggested is fine, but wild cards
in names is not. It's gone wrong far too often in the past.
Much better to just pick a supported part and stick to that for naming.
Obviously that's tricky here as you want to reuse the same name hence..
Clunky though it may seem ltc2497-core.c ltc2497 and ltc2496 would be my
suggestion..
>
> Also I didn't merge the binding docs of ltc2496 and ltc2497 for the same
> reason. I'm still not entirely happy with the (now) yaml document. I'd
> like to have a statement that says: This is an spi device, so it might
> have all the properties described in
> Documentation/devicetree/bindings/spi/spi-controller.yaml for an SPI
> device.
I don't think the is any way of doing this. For standard elements you
normally just list them with no help etc.
>
> Uwe Kleine-König (3):
> iio: adc: ltc2496: provide device tree binding document
> iio: adc: ltc2497: split protocol independent part in a separate
> module
> iio: adc: new driver to support Linear technology's ltc2496
>
> .../bindings/iio/adc/lltc,ltc2496.yaml | 30 +++
> MAINTAINERS | 2 +-
> drivers/iio/adc/Kconfig | 10 +
> drivers/iio/adc/Makefile | 3 +-
> drivers/iio/adc/ltc2496.c | 100 +++++++
> drivers/iio/adc/ltc2497.c | 237 ++---------------
> drivers/iio/adc/ltc249x.c | 244 ++++++++++++++++++
> drivers/iio/adc/ltc249x.h | 18 ++
> 8 files changed, 433 insertions(+), 211 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/lltc,ltc2496.yaml
> create mode 100644 drivers/iio/adc/ltc2496.c
> create mode 100644 drivers/iio/adc/ltc249x.c
> create mode 100644 drivers/iio/adc/ltc249x.h
>
>
> base-commit: 31f4f5b495a62c9a8b15b1c3581acd5efeb9af8c
prev parent reply other threads:[~2019-11-16 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 10:51 [PATCH v2 0/3] iio: adc: add support for ltc2496 Uwe Kleine-König
2019-11-14 10:51 ` [RFC PATCH v2 1/3] iio: adc: ltc2496: provide device tree binding document Uwe Kleine-König
2019-11-14 10:51 ` [PATCH v2 2/3] iio: adc: ltc2497: split protocol independent part in a separate module Uwe Kleine-König
2019-11-16 15:58 ` Jonathan Cameron
2019-11-16 16:00 ` Jonathan Cameron
2019-11-14 10:51 ` [PATCH v2 3/3] iio: adc: new driver to support Linear technology's ltc2496 Uwe Kleine-König
2019-11-16 16:09 ` Jonathan Cameron
2019-11-16 15:31 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191116153108.578020f8@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=kernel@pengutronix.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=stefan.popa@analog.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox