From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<nuno.sa@analog.com>, <Michael.Hennerich@analog.com>
Subject: Re: [PATCH v2 00/11] iio: imu: adis: cleanup lock usage
Date: Sat, 23 Nov 2019 12:21:53 +0000 [thread overview]
Message-ID: <20191123122153.76fbbc2a@archlinux> (raw)
In-Reply-To: <20191122132421.5500-1-alexandru.ardelean@analog.com>
On Fri, 22 Nov 2019 15:24:10 +0200
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> There is a general effort for cleaning up `indio_dev->mlock` usage in IIO
> drivers. As part of that some ADIS drivers also need to do that.
>
> This changeset does a little more, by reworking the `txrx_lock` from the
> ADIS library to be used as a general `state_lock` to protect state between
> consecutive read/write ops.
>
> As such, all users of the ADIS lib have been verified to have their usage
> of mlock checked. Some just needed the mlock usage removed (as done in
>
> Changelog v1 -> v2:
> * this patchset has got more testing in our repo since last time - also
> found a bug in v1
> * tested with `make ARCH=x86_64 allmodconfig` ; seems this is how Greg
> found the issue and we didn't
>
> Alexandru Ardelean (11):
> iio: imu: adis: rename txrx_lock -> state_lock
> iio: imu: adis: add unlocked read/write function versions
> iio: imu: adis[16480]: group RW into a single lock in
> adis_enable_irq()
> iio: imu: adis: create an unlocked version of adis_check_status()
> iio: imu: adis: create an unlocked version of adis_reset()
> iio: imu: adis: protect initial startup routine with state lock
> iio: imu: adis: group single conversion under a single state lock
> iio: imu: adis16400: rework locks using ADIS library's state lock
> iio: gyro: adis16136: rework locks using ADIS library's state lock
> iio: imu: adis16480: use state lock for filter freq set
> iio: gyro: adis16260: replace mlock with ADIS lib's state_lock
>
> drivers/iio/gyro/adis16136.c | 31 ++++---
> drivers/iio/gyro/adis16260.c | 6 +-
> drivers/iio/imu/adis.c | 94 +++++++++++----------
> drivers/iio/imu/adis16400.c | 51 ++++++------
> drivers/iio/imu/adis16480.c | 17 ++--
> drivers/iio/imu/adis_buffer.c | 4 +-
> include/linux/iio/imu/adis.h | 150 ++++++++++++++++++++++++++++++++--
> 7 files changed, 258 insertions(+), 95 deletions(-)
>
All applied to the togreg branch of iio.git and pushed out as testing to
get some build coverage.
Thanks,
Jonathan
prev parent reply other threads:[~2019-11-23 12:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 13:24 [PATCH v2 00/11] iio: imu: adis: cleanup lock usage Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 01/11] iio: imu: adis: rename txrx_lock -> state_lock Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 02/11] iio: imu: adis: add unlocked read/write function versions Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 03/11] iio: imu: adis[16480]: group RW into a single lock in adis_enable_irq() Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 04/11] iio: imu: adis: create an unlocked version of adis_check_status() Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 05/11] iio: imu: adis: create an unlocked version of adis_reset() Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 06/11] iio: imu: adis: protect initial startup routine with state lock Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 07/11] iio: imu: adis: group single conversion under a single " Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 08/11] iio: imu: adis16400: rework locks using ADIS library's " Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 09/11] iio: gyro: adis16136: " Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 10/11] iio: imu: adis16480: use state lock for filter freq set Alexandru Ardelean
2019-11-22 13:24 ` [PATCH v2 11/11] iio: gyro: adis16260: replace mlock with ADIS lib's state_lock Alexandru Ardelean
2019-11-23 12:21 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191123122153.76fbbc2a@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).