Re: [PATCH v2 0/3] Add support for DLH pressure sensors

Jonathan Cameron
2019-12-01T10:27:17Z

On Fri, 29 Nov 2019 08:34:17 +0100
<tomislav.denis@avl.com> wrote:

> From: Tomislav Denis <tomislav.denis@avl.com>
>
> This patchset adds support for All Sensors DLH series low
> voltage digital pressure sensors.
>
> Datasheet: https://www.allsensors.com/cad/DS-0355_Rev_B.PDF
One generic comment before I look at the code.

Mostly (there may be exceptions) it is better to post a new version
as a separate email thread. This avoid deep and extremely confusing
threads when we run into many versions. Also, a lot of maintainers
have limited time so start at their most recent emails on the basis
that earlier discussions have often already been resolved by other
reviewers / contributors. If you send in a reply to an older thread
you reduce the chance of anyone looking at it ;)

Thanks,

Jonathan

>
> Changes in v2:
> - web page link in the MAINTAINERS file fixed
> - adjust the units of the output to the IIO ABI
> - unneceseary default case removed
> - define the channel member of the iio_chan_spec
> struct for channels specification
> - remove explicit cast for pointers of type void *
> - add support for the EOC(data ready) pin
> - drop the unneceseary return ret;
> - rename dlh-i2c.yaml to asc,dlh-i2c.yaml
> - change the bindings copyright to GPL-2.0-only OR BSD-2-Clause
> - document EOC(data ready) pin
>
> Tomislav Denis (3):
> iio: pressure: Add driver for DLH pressure sensors
> dt-bindings: Add asc vendor
> bindings: iio: pressure: Add dlh-i2c documentation
>
> .../bindings/iio/pressure/asc,dlh-i2c.yaml | 51 +++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> MAINTAINERS | 8 +
> drivers/iio/pressure/Kconfig | 12 +
> drivers/iio/pressure/Makefile | 1 +
> drivers/iio/pressure/dlh-i2c.c | 429 +++++++++++++++++++++
> 6 files changed, 503 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/pressure/asc,dlh-i2c.yaml
> create mode 100644 drivers/iio/pressure/dlh-i2c.c
>