Re: [PATCH 3/3] bindings: iio: pressure: Add dlh-i2c documentation

Jonathan Cameron
2019-11-14T14:13:14Z

On Thu, 14 Nov 2019 11:09:08 +0100
<tomislav.denis@avl.com> wrote:

> From: Tomislav Denis <tomislav.denis@avl.com>
>
> Add a device tree binding documentation for DLH series pressure
> sensors.
>
> Signed-off-by: Tomislav Denis <tomislav.denis@avl.com>
Hi Tomislav,

A few little comments inline

Thanks,

Jonathan

> ---
> .../devicetree/bindings/iio/pressure/dlh-i2c.yaml | 43 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/pressure/dlh-i2c.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/pressure/dlh-i2c.yaml b/Documentation/devicetree/bindings/iio/pressure/dlh-i2c.yaml
> new file mode 100644
> index 0000000..43539ba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/dlh-i2c.yaml

prefix the filename as per the compatible - so
asc,slh-i2c.yaml

> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: GPL-2.0

I'm guessing you own the copyright on this binding. Where possible
the DT maintainers are requesting that bindings are dual licensed as
(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/pressure/dlh-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: All Sensors DLH series low voltage digital pressure sensors
> +
> +maintainers:
> + - Tomislav Denis <tomislav.denis@avl.com>
> +
> +description: |
> + Bindings for the All Sensors DLH series pressure sensors.
> +
> + Specifications about the sensors can be found at:
> + http://www.allsensors.com/cad/DS-0355_Rev_B.PDF

I took a quick look at the datasheet. Whilst I guess you don't have
it wired up, there is an EOC line which should be here as the
doc should cover the hardware, rather than what we currently
use in the driver. The EOC line looks like a data ready
interrupt from my quick read.

> +
> +properties:
> + compatible:
> + enum:
> + - asc,dlhl60d
> + - asc,dlhl60g
> +
> + reg:
> + description: I2C device address
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pressure@29 {
> + compatible = "asc,dlhl60d";
> + reg = <0x29>;
> + };
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2a08923..b45081d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -674,6 +674,7 @@ W: http://www.allsensors.com/cad/DS-0355_Rev_B.PDF
> S: Maintained
> L: linux-iio@vger.kernel.org
> F: drivers/iio/pressure/dlh-i2c.c
> +F: Documentation/devicetree/bindings/iio/pressure/dlh-i2c.yaml
>
> ALLEGRO DVT VIDEO IP CORE DRIVER
> M: Michael Tretter <m.tretter@pengutronix.de>