From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH] iio: ak8975: Convert to use GPIO descriptor
Date: Fri, 6 Dec 2019 17:43:00 +0000 [thread overview]
Message-ID: <20191206174300.03541cf4@archlinux> (raw)
In-Reply-To: <20191202125756.GF32742@smile.fi.intel.com>
On Mon, 2 Dec 2019 14:57:56 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Mon, Dec 02, 2019 at 02:51:48PM +0200, Andy Shevchenko wrote:
> > On Mon, Dec 02, 2019 at 09:17:30AM +0100, Linus Walleij wrote:
> > > The end-of-conversion (EOC) GPIO line is better to grab using
> > > a GPIO descriptor. We drop the pdata for this: clients using board
> > > files can use machine descriptor tables to pass this GPIO from
> > > static data.
>
> > > dev_err(&client->dev,
> > > - "irq %d request failed, (gpio %d): %d\n",
> > > - irq, data->eoc_gpio, rc);
> > > + "irq %d request failed: %d\n",
> > > + irq, rc);
> >
> > Now it fits one line.
>
> I meant including dev_err().
>
Tidied up whilst applying. Applied to the togreg branch of iio.git.
Pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
prev parent reply other threads:[~2019-12-06 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 8:17 [PATCH] iio: ak8975: Convert to use GPIO descriptor Linus Walleij
2019-12-02 12:51 ` Andy Shevchenko
2019-12-02 12:57 ` Andy Shevchenko
2019-12-06 17:43 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206174300.03541cf4@archlinux \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox