Re: [PATCH 03/10] dt-bindings: iio: trigger: at91-rtc-trigger: add bindings

Jonathan Cameron
2019-12-23T12:01:49Z

On Wed, 18 Dec 2019 16:23:59 +0000
<Eugen.Hristev@microchip.com> wrote:

> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> Add bindings for AT91 RTC ADC Trigger hardware node.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
If this does make sense (under discussion) I think it should be in
the rtc binding doc. This doesn't make it explicit that this particular
block is a child node of that block as far as I can see...

Jonathan

> ---
> .../bindings/iio/trigger/at91-rtc-trigger.yaml | 44 ++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 040000 Documentation/devicetree/bindings/iio/trigger
> create mode 100644 Documentation/devicetree/bindings/iio/trigger/at91-rtc-trigger.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/trigger/at91-rtc-trigger.yaml b/Documentation/devicetree/bindings/iio/trigger/at91-rtc-trigger.yaml
> new file mode 100644
> index 0000000..c8c5886
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/trigger/at91-rtc-trigger.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright 2019 Eugen Hristev <eugen.hristev@gmail.com>
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/bindings/iio/trigger/microchip,rtc-adc-trigger.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Microchip AT91 RTC ADC Trigger (Real Time Clock to Analog to Digital Converter)
> +
> +maintainers:
> + - Eugen Hristev <eugen.hristev@microchip.com>
> +
> +description: |
> + Bindings for the Microchip AT91 RTC ADC Trigger.
> + The Real Time Clock block inside AT91 SoCs can be connected with a direct
> + hardware line to the ADC. This line can be raised at a specific time
> + interval in order to trigger the ADC to perform conversions.
> + Datasheet can be found here: http://ww1.microchip.com/downloads/en/devicedoc/ds60001476b.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - microchip,rtc-adc-trigger
> +
> + reg:
> + description: |
> + Register map address (start address, size).
> + maxItems: 2
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + {
> + #address_cells = <1>;
> + #size-cells = <1>;
> +
> + rtc_adc_trigger: rtc-adc-trigger {
> + reg = <0x0 0x10>;
> + compatible = "microchip,rtc-adc-trigger";
> + };
> + };