From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: chemical: atlas-ph-sensor: rename atlas-ph-sensor to atlas-sensor
Date: Mon, 23 Dec 2019 16:32:22 +0000 [thread overview]
Message-ID: <20191223163222.6039c888@archlinux> (raw)
In-Reply-To: <20191216000045.30482-1-matt.ranostay@konsulko.com>
On Sun, 15 Dec 2019 16:00:45 -0800
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> Since the orginal scope of the driver was to only support
> the pH product from Atlas it has evolved to other sensors.
>
> Rename the file, driver name, and regmap to atlas-sensor which
> reflects this, although keep CONFIG_ATLAS_PH_SENSOR to not cause
> regressions with current configurations.
>
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Seems reasonable.
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/chemical/Makefile | 2 +-
> .../iio/chemical/{atlas-ph-sensor.c => atlas-sensor.c} | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
> rename drivers/iio/chemical/{atlas-ph-sensor.c => atlas-sensor.c} (98%)
>
> diff --git a/drivers/iio/chemical/Makefile b/drivers/iio/chemical/Makefile
> index f97270bc4034..33d3a595dda9 100644
> --- a/drivers/iio/chemical/Makefile
> +++ b/drivers/iio/chemical/Makefile
> @@ -4,7 +4,7 @@
> #
>
> # When adding new entries keep the list in alphabetical order
> -obj-$(CONFIG_ATLAS_PH_SENSOR) += atlas-ph-sensor.o
> +obj-$(CONFIG_ATLAS_PH_SENSOR) += atlas-sensor.o
> obj-$(CONFIG_BME680) += bme680_core.o
> obj-$(CONFIG_BME680_I2C) += bme680_i2c.o
> obj-$(CONFIG_BME680_SPI) += bme680_spi.o
> diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-sensor.c
> similarity index 98%
> rename from drivers/iio/chemical/atlas-ph-sensor.c
> rename to drivers/iio/chemical/atlas-sensor.c
> index 6c175eb1c7a7..8cd76d828646 100644
> --- a/drivers/iio/chemical/atlas-ph-sensor.c
> +++ b/drivers/iio/chemical/atlas-sensor.c
> @@ -1,8 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0+
> /*
> - * atlas-ph-sensor.c - Support for Atlas Scientific OEM pH-SM sensor
> + * atlas-sensor.c - Support for Atlas Scientific OEM SM sensors
> *
> - * Copyright (C) 2015-2018 Matt Ranostay
> + * Copyright (C) 2015-2019 Konsulko Group
> * Author: Matt Ranostay <matt.ranostay@konsulko.com>
> */
>
> @@ -25,8 +25,8 @@
> #include <linux/iio/triggered_buffer.h>
> #include <linux/pm_runtime.h>
>
> -#define ATLAS_REGMAP_NAME "atlas_ph_regmap"
> -#define ATLAS_DRV_NAME "atlas_ph"
> +#define ATLAS_REGMAP_NAME "atlas_regmap"
> +#define ATLAS_DRV_NAME "atlas"
>
> #define ATLAS_REG_DEV_TYPE 0x00
> #define ATLAS_REG_DEV_VERSION 0x01
> @@ -681,5 +681,5 @@ static struct i2c_driver atlas_driver = {
> module_i2c_driver(atlas_driver);
>
> MODULE_AUTHOR("Matt Ranostay <matt.ranostay@konsulko.com>");
> -MODULE_DESCRIPTION("Atlas Scientific pH-SM sensor");
> +MODULE_DESCRIPTION("Atlas Scientific SM sensors");
> MODULE_LICENSE("GPL");
prev parent reply other threads:[~2019-12-23 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 0:00 [PATCH] iio: chemical: atlas-ph-sensor: rename atlas-ph-sensor to atlas-sensor Matt Ranostay
2019-12-23 16:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223163222.6039c888@archlinux \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox