From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB72C2D0C0 for ; Mon, 23 Dec 2019 17:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE0F820709 for ; Mon, 23 Dec 2019 17:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577123944; bh=WDqjT+YtE+Wo+JuMu1GzKuJojCfXUOurRzYLLDjl+fk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=zJYKHUSCMELsqXMIPqnWrlzehlUj8ZLlgeJMtWUEDjPimMjZ290ctmXoD3flozBNy bx0GpdVzXi8xrX758N7T5XcsvYLtSt6PkTefOWCcwODuPc5JC4RM40yOEurBDyCYkm E2ZiU2jeOThW973r8MJEW9zY1hkQxWv40gcr+COE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726783AbfLWR7D (ORCPT ); Mon, 23 Dec 2019 12:59:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:35794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbfLWR7A (ORCPT ); Mon, 23 Dec 2019 12:59:00 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8A6820643; Mon, 23 Dec 2019 17:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577123939; bh=WDqjT+YtE+Wo+JuMu1GzKuJojCfXUOurRzYLLDjl+fk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V8jLtzGq3fCk6dsOWYtDeI0b7gHsLlbtcEf4u/uwviPB7/G1TIET9udfkOtomfBwg ROOV/zhNUyj8FgivdF782xpdSc/chzKfxL43Ov8BjcVXFKEG+gZFXlE5KiZ7vDtwtd KrxkTxY4cNNgTZ2E/EtKfa/sUnf1euiY/qPP2n+w= Date: Mon, 23 Dec 2019 17:58:54 +0000 From: Jonathan Cameron To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Mark Rutland , Lars-Peter Clausen , Stefan Popa , Michael Hennerich , linux-iio@vger.kernel.org, Rob Herring , Peter Meerwald-Stadler , Hartmut Knaack , Alexandru Ardelean , kernel@pengutronix.de Subject: Re: [PATCH v4 1/3] iio: adc: ltc2496: provide device tree binding document Message-ID: <20191223175854.600c7254@archlinux> In-Reply-To: <20191216083736.lzmborv33w6odlaj@pengutronix.de> References: <20191209203248.21555-1-u.kleine-koenig@pengutronix.de> <20191209203248.21555-2-u.kleine-koenig@pengutronix.de> <20191215114958.6ad37d19@archlinux> <20191216083736.lzmborv33w6odlaj@pengutronix.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 16 Dec 2019 09:37:36 +0100 Uwe Kleine-K=C3=B6nig wrote: > Hello Jonathan, >=20 > On Sun, Dec 15, 2019 at 11:49:58AM +0000, Jonathan Cameron wrote: > > On Mon, 9 Dec 2019 21:32:46 +0100 > > Uwe Kleine-K=C3=B6nig wrote: > > =20 > > > The ADC only requires the standard stuff for spi devices and a refere= nce > > > voltage. > > >=20 > > > Signed-off-by: Uwe Kleine-K=C3=B6nig = =20 > > Thanks for figuring out what was wrong and fixing it up. =20 >=20 > It wasn't done primarily to do you a favour :-) >=20 > > > + spi-max-frequency: > > > + description: maximal spi bus frequency supported by the chip =20 > >=20 > > dropped the "by the chip" as this is also about the wiring on the board= . If it > > were just the chip, it could be put in the driver. The unknown bit is > > if there is some other reason why it might need to be set lower than th= e maximum. =20 >=20 > fine for me. >=20 > > > +required: > > > + - compatible > > > + - vref-supply > > > + - reg > > > + > > > +examples: > > > + - | > > > + spi { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + adc@0 { > > > + compatible =3D "lltc,ltc2496"; =20 > > You can't easily see it here, but this is a mixture of spaces > > and tabs. Should be all spaces. I've tidied that up. =20 >=20 > I did that on purpose, spaces to have the needed indention for the yaml > syntax and then tabs for dts indention (as done in the dts itself, too). > I thought this to be the right mix, but this was my first yaml binding, > so you're probably right. I'll be honest, I'm far from sure on this. I usually rely on Rob moaning about it if it's wrong :) Oh well. What's there builds. If we get a 'fix' later then so be it. Thanks, Jonathan >=20 > Best regards and thanks > Uwe >=20