From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40816C3F68F for ; Wed, 8 Jan 2020 20:23:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 114B920838 for ; Wed, 8 Jan 2020 20:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578515025; bh=ZLr9BMWOVS7n6pXaLQX/xV84CpdanYIZt+grLBd5fY0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=iI2QMYU7FWFut2ZAXL9mqHY1N9PQqstMMiLFbudxwckB7UdBYsXZZ4jcv9GhhoRQQ 3Dgp1U1wD/V8a2uRK3IWD5MVuo4LW9FmqiLsdaDgDe7d937EvTXQm+9lXHf3GXju7E 1RBnD/rejMYZvLit9vtK6Mu5AtJ9Xv37bEJcgoio= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725881AbgAHUXo (ORCPT ); Wed, 8 Jan 2020 15:23:44 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:39925 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbgAHUXo (ORCPT ); Wed, 8 Jan 2020 15:23:44 -0500 Received: by mail-oi1-f194.google.com with SMTP id a67so3857819oib.6 for ; Wed, 08 Jan 2020 12:23:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jqJ3Kb99ht0XkZVU8yBDUn07MFCSBOIqQAw6O1B1GBc=; b=lVTt/ZMlCGZqDeQheCDRAmaevWZVADWsvxgr8uVsHFv2codIe3mre1W1x+M3tp6QpQ PYRea9vlrFD6afpzyw4qV004wkE1Lgtus9mbsiZhhToI9jSU8x1Ljdw981cqr5JZSVPt 8C40yNxR8dR05OzTOFWT/nm0Z4fXMkoMP1481PmvggFsHv4hXj0kNQMLQN8QvxX0r8fL h9UJZy7cMY1B1aGAEV99p0t5MuxMk0tfHJfnp9bQh2Hpclq3LyCnx8EdRGngaFUArSVY moOm/1qGPr+QCkrvwJFghQ1CZ2XdFhMvSfqJSYdT9Y/0CA1+ONLaPXXFPeBPQWOEuSi6 9onA== X-Gm-Message-State: APjAAAWDOQSxCLUaAzu2+l3kYC8Fe9X/89CVku/rtsgZiLcBnPCGi7nu VqZea4SwwMXIqR0qmpdSdX1YEfk= X-Google-Smtp-Source: APXvYqzmN2ZsWy+vK4Oi/1jB5WE+K+EA89N9iZIjhpHj7Sz7qrAVkazb4jXYqGBqHD6K7cpunhib3g== X-Received: by 2002:aca:4183:: with SMTP id o125mr299177oia.125.1578515023044; Wed, 08 Jan 2020 12:23:43 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id v21sm1464884otr.72.2020.01.08.12.23.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2020 12:23:42 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2208fa by rob-hp-laptop (DragonFly Mail Agent v0.11); Wed, 08 Jan 2020 14:23:41 -0600 Date: Wed, 8 Jan 2020 14:23:41 -0600 From: Rob Herring To: Matt Ranostay Cc: linux-iio@vger.kernel.org, jic23@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] iio: chemical: atlas-sensor: add DO-SM module support Message-ID: <20200108202341.GA28838@bogus> References: <20200106090335.21717-1-matt.ranostay@konsulko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200106090335.21717-1-matt.ranostay@konsulko.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, Jan 06, 2020 at 01:03:35AM -0800, Matt Ranostay wrote: > Atlas Scientific DO-SM OEM sensor reads disolved oxygen in > a solution. This is reported back as mg/L which maps directly > to ppm and so the IIO_CONCENTRATION channel type can be used. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Matt Ranostay > --- > .../bindings/iio/chemical/atlas,do-sm.txt | 21 ++++++ Please split bindings to separate patch and make this a DT schema. It seems like all these Atlas sensors are the same. Can you combine them into one schema? > drivers/iio/chemical/atlas-sensor.c | 64 +++++++++++++++++-- > 2 files changed, 81 insertions(+), 4 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,do-sm.txt > > diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,do-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,do-sm.txt > new file mode 100644 > index 000000000000..fc741ea794c4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/atlas,do-sm.txt > @@ -0,0 +1,21 @@ > +* Atlas Scientific DO-SM OEM sensor > + > +http://www.atlas-scientific.com/_files/_datasheets/_oem/DO_oem_datasheet.pdf > + > +Required properties: > + > + - compatible: must be "atlas,do-sm" > + - reg: the I2C address of the sensor > + - interrupts: the sole interrupt generated by the device > + > + Refer to interrupt-controller/interrupts.txt for generic interrupt client > + node bindings. > + > +Example: > + > +atlas@64 { > + compatible = "atlas,do-sm"; > + reg = <0x67>; > + interrupt-parent = <&gpio1>; > + interrupts = <16 2>; > +};