From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB259C33CB1 for ; Sat, 18 Jan 2020 13:34:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F8AE2469A for ; Sat, 18 Jan 2020 13:34:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579354473; bh=/omhXstJLHdtzfL5ZXSP8ni+4NjJtg5VWsRMdJIlRc0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=VG7adFSZ5gFYL2TuaiR/ddLL0HkDaIRGMGoJkO8PalaCXrM2S730Qp3UpfTu4RGLK dLZE0V33LP6fk/xwWxJwZxJtU5QlKPR2xg2zaQmiVrt4rHN0N6WyYLopMZdG7lKkKr 9owycnKy+C2fdfSVl/7ZzMvg464Mzn7yTLwv0/uc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727043AbgARNec (ORCPT ); Sat, 18 Jan 2020 08:34:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:50090 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727032AbgARNec (ORCPT ); Sat, 18 Jan 2020 08:34:32 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87E8C24699; Sat, 18 Jan 2020 13:34:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579354472; bh=/omhXstJLHdtzfL5ZXSP8ni+4NjJtg5VWsRMdJIlRc0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gN2+giLR8KsEq+xbkU6SDX15RgiV/I3Ly1v4hIefxhkGzKWy9EcQIvmgdO7oigbBD y6kBIJ8dOhizPLSl09bxI54rieOQU6OpGX5WHDweDWwH9MveG6nzmnB2rx6AmomTly eVY+NzKYRBpSL7TpAPo0l/JnXoqQt7p8gE+78vek= Date: Sat, 18 Jan 2020 13:34:27 +0000 From: Jonathan Cameron To: Dan Carpenter Cc: Dan Robertson , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Andy Shevchenko , Linus Walleij , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] iio: accel: bma400: prevent setting accel scale too low Message-ID: <20200118133427.07a665f6@archlinux> In-Reply-To: <20200116100829.thq77nvyqtasdu4j@kili.mountain> References: <20200115181717.GA22797@nessie> <20200116100829.thq77nvyqtasdu4j@kili.mountain> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 16 Jan 2020 13:08:29 +0300 Dan Carpenter wrote: > This puts an upper bound on "val2" but it also needs to have a lower > bound (BMA400_SCALE_MIN). > > Fixes: 465c811f1f20 ("iio: accel: Add driver for the BMA400") > Signed-off-by: Dan Carpenter Applied to the togreg branch of iio.git and pushed out as testing. Hopefully I'll sneak in a pull request to get this lined up for the merge window. Thanks, Jonathan > --- > v2: the first version just capped it at zero but it should be > BMA400_SCALE_MIN (38357). > > drivers/iio/accel/bma400_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c > index ab4a158b35af..cc77f89c048b 100644 > --- a/drivers/iio/accel/bma400_core.c > +++ b/drivers/iio/accel/bma400_core.c > @@ -752,7 +752,8 @@ static int bma400_write_raw(struct iio_dev *indio_dev, > mutex_unlock(&data->mutex); > return ret; > case IIO_CHAN_INFO_SCALE: > - if (val != 0 || val2 > BMA400_SCALE_MAX) > + if (val != 0 || > + val2 < BMA400_SCALE_MIN || val2 > BMA400_SCALE_MAX) > return -EINVAL; > > mutex_lock(&data->mutex);