Re: [PATCH v4 2/2] Device tree bindings for TI HDC20x0 humidity and temperature sensors

Rob Herring
2020-01-27T15:54:25Z

On Thu, Jan 23, 2020 at 09:19:12PM +0000, Eugene Zalkonnikov wrote:
> Signed-off-by: Eugene Zaikonnikov <eugene.zaikonnikov@norphonic.com>
>
> diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml
> --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100
> +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml 2020-01-23 17:13:51.573766898 +0100

Full compatible string for filename is preferred: ti,hdc2010.yaml

> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/humidity/hdc2010.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HDC2010/HDC2080 humidity and temperature iio sensors
> +
> +maintainers:
> + - Eugene Zaikonnikov <eugene.zaikonnikov@norophonic.com>
> +
> +description: |
> + Relative humidity and tempereature sensors on I2C bus

checkpatch.pl reports a typo.

> +
> + Datasheets are available at:
> + http://www.ti.com/product/HDC2010/datasheet
> + http://www.ti.com/product/HDC2080/datasheet
> +
> +properties:
> + compatible:
> + enum:
> + - ti,hdc2010
> + - ti,hdc2080
> +
> + vddd-supply:
> + description:
> + digital voltage regulator (see regulator/regulator.txt)
> + maxItems: 1
> +
> + interrupts:
> + description:
> + interrupt mapping for IRQ

Drop this. Nothing specific here for this binding.

> + maxItems: 1
> +
> +required:
> + - compatible
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hdc200x@40 {
> + compatible = "ti,hdc2010";
> + reg = <0x40>;
> + };
> + };
>