From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F50DC2D0B1 for ; Thu, 6 Feb 2020 10:01:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07CFE214AF for ; Thu, 6 Feb 2020 10:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580983285; bh=At5VW7ePgEnZMtBFcDpO/YmpFI56dpz5ypoLKjKah/I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=CpG/IsFTN6b2Eoa8Wtb9R/IIGTJEghndCKzQu4DBi8p9D9d9BtpH4RVympSX8z/5K wI/+PrHtghlzJAPI+kRROHu7r/965U04ymi6Lgm4Dacnc1Imvnf6uqqJ2xSe58wVFp i8A4NdzNX/SzhLRtVYZRA6J/GTqr5kLlN9x8s6Wk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728225AbgBFKBY (ORCPT ); Thu, 6 Feb 2020 05:01:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:36170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728146AbgBFKBY (ORCPT ); Thu, 6 Feb 2020 05:01:24 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E230214AF; Thu, 6 Feb 2020 10:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580983283; bh=At5VW7ePgEnZMtBFcDpO/YmpFI56dpz5ypoLKjKah/I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JhxhdK1cVS6pvBV+/q8jFMikQOmDQjbYKfu73XGZwT3X8ryTcbw3NKc1EjvUQeiOA 8t5Nu/Yy+BBY3c5/qfE22LKJ7AS3AZb45cpnqB80BJ2xSP6d90mY5fL1nWHK0B3deZ qjUobCcgYt/i3vOUB9CGcUU4kMXphJSIKMhh8Z7c= Date: Thu, 6 Feb 2020 10:01:19 +0000 From: Jonathan Cameron To: Alexandru Tachici Cc: , Subject: Re: [PATCH 2/5 V2] staging: iio: adc: ad7192: modify iio_chan_spec array Message-ID: <20200206100119.0ad268a2@archlinux> In-Reply-To: <20200205171511.25912-3-alexandru.tachici@analog.com> References: <20200202162215.50915c83@archlinux> <20200205171511.25912-1-alexandru.tachici@analog.com> <20200205171511.25912-3-alexandru.tachici@analog.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 5 Feb 2020 19:15:08 +0200 Alexandru Tachici wrote: > This patch changes the static const struct iio_chan_spec arrays > in a way that all the necessary attributes are set at > compile time. Now ad7192_channels_config only makes the > channels attribute of iio_dev point to the right array depending > on the chip. > > Signed-off-by: Alexandru Tachici Great. Not directly related to this patch, but a question about docs inline. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7192.c | 112 ++++++++++++++++++------------- > 1 file changed, 66 insertions(+), 46 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > index 4780ddf99b13..8f2fa154876a 100644 > --- a/drivers/staging/iio/adc/ad7192.c > +++ b/drivers/staging/iio/adc/ad7192.c > @@ -786,73 +786,93 @@ static const struct iio_info ad7195_info = { > .validate_trigger = ad_sd_validate_trigger, > }; > > +#define __AD719x_CHANNEL(_si, _channel1, _channel2, _address, _extend_name, \ > + _type, _mask_type_av, _ext_info) \ > + { \ > + .type = (_type), \ > + .differential = ((_channel2) == -1 ? 0 : 1), \ > + .indexed = 1, \ > + .channel = (_channel1), \ > + .channel2 = (_channel2), \ > + .address = (_address), \ > + .extend_name = (_extend_name), \ > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ > + BIT(IIO_CHAN_INFO_OFFSET), \ > + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \ > + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ) | \ > + BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY), \ > + .info_mask_shared_by_type_available = (_mask_type_av), \ > + .ext_info = (_ext_info), \ > + .scan_index = (_si), \ > + .scan_type = { \ > + .sign = 'u', \ > + .realbits = 24, \ > + .storagebits = 32, \ > + .endianness = IIO_BE, \ > + }, \ > + } > + > +#define AD719x_DIFF_CHANNEL(_si, _channel1, _channel2, _address) \ > + __AD719x_CHANNEL(_si, _channel1, _channel2, _address, NULL, \ > + IIO_VOLTAGE, BIT(IIO_CHAN_INFO_SCALE), \ > + ad7192_calibsys_ext_info) > + > +#define AD719x_CHANNEL(_si, _channel1, _address) \ > + __AD719x_CHANNEL(_si, _channel1, -1, _address, NULL, IIO_VOLTAGE, \ > + BIT(IIO_CHAN_INFO_SCALE), ad7192_calibsys_ext_info) > + > +#define AD719x_SHORTED_CHANNEL(_si, _channel1, _address) \ > + __AD719x_CHANNEL(_si, _channel1, -1, _address, "shorted", IIO_VOLTAGE, \ > + BIT(IIO_CHAN_INFO_SCALE), ad7192_calibsys_ext_info) Just to check, is this one documented? It will result in new ABI afterall. > + > +#define AD719x_TEMP_CHANNEL(_si, _address) \ > + __AD719x_CHANNEL(_si, 0, -1, _address, NULL, IIO_TEMP, 0, NULL) > + > static const struct iio_chan_spec ad7192_channels[] = { > - AD_SD_DIFF_CHANNEL(0, 1, 2, AD7192_CH_AIN1P_AIN2M, 24, 32, 0), > - AD_SD_DIFF_CHANNEL(1, 3, 4, AD7192_CH_AIN3P_AIN4M, 24, 32, 0), > - AD_SD_TEMP_CHANNEL(2, AD7192_CH_TEMP, 24, 32, 0), > - AD_SD_SHORTED_CHANNEL(3, 2, AD7192_CH_AIN2P_AIN2M, 24, 32, 0), > - AD_SD_CHANNEL(4, 1, AD7192_CH_AIN1, 24, 32, 0), > - AD_SD_CHANNEL(5, 2, AD7192_CH_AIN2, 24, 32, 0), > - AD_SD_CHANNEL(6, 3, AD7192_CH_AIN3, 24, 32, 0), > - AD_SD_CHANNEL(7, 4, AD7192_CH_AIN4, 24, 32, 0), > + AD719x_DIFF_CHANNEL(0, 1, 2, AD7192_CH_AIN1P_AIN2M), > + AD719x_DIFF_CHANNEL(1, 3, 4, AD7192_CH_AIN3P_AIN4M), > + AD719x_TEMP_CHANNEL(2, AD7192_CH_TEMP), > + AD719x_SHORTED_CHANNEL(3, 2, AD7192_CH_AIN2P_AIN2M), > + AD719x_CHANNEL(4, 1, AD7192_CH_AIN1), > + AD719x_CHANNEL(5, 2, AD7192_CH_AIN2), > + AD719x_CHANNEL(6, 3, AD7192_CH_AIN3), > + AD719x_CHANNEL(7, 4, AD7192_CH_AIN4), > IIO_CHAN_SOFT_TIMESTAMP(8), > }; > > static const struct iio_chan_spec ad7193_channels[] = { > - AD_SD_DIFF_CHANNEL(0, 1, 2, AD7193_CH_AIN1P_AIN2M, 24, 32, 0), > - AD_SD_DIFF_CHANNEL(1, 3, 4, AD7193_CH_AIN3P_AIN4M, 24, 32, 0), > - AD_SD_DIFF_CHANNEL(2, 5, 6, AD7193_CH_AIN5P_AIN6M, 24, 32, 0), > - AD_SD_DIFF_CHANNEL(3, 7, 8, AD7193_CH_AIN7P_AIN8M, 24, 32, 0), > - AD_SD_TEMP_CHANNEL(4, AD7193_CH_TEMP, 24, 32, 0), > - AD_SD_SHORTED_CHANNEL(5, 2, AD7193_CH_AIN2P_AIN2M, 24, 32, 0), > - AD_SD_CHANNEL(6, 1, AD7193_CH_AIN1, 24, 32, 0), > - AD_SD_CHANNEL(7, 2, AD7193_CH_AIN2, 24, 32, 0), > - AD_SD_CHANNEL(8, 3, AD7193_CH_AIN3, 24, 32, 0), > - AD_SD_CHANNEL(9, 4, AD7193_CH_AIN4, 24, 32, 0), > - AD_SD_CHANNEL(10, 5, AD7193_CH_AIN5, 24, 32, 0), > - AD_SD_CHANNEL(11, 6, AD7193_CH_AIN6, 24, 32, 0), > - AD_SD_CHANNEL(12, 7, AD7193_CH_AIN7, 24, 32, 0), > - AD_SD_CHANNEL(13, 8, AD7193_CH_AIN8, 24, 32, 0), > + AD719x_DIFF_CHANNEL(0, 1, 2, AD7193_CH_AIN1P_AIN2M), > + AD719x_DIFF_CHANNEL(1, 3, 4, AD7193_CH_AIN3P_AIN4M), > + AD719x_DIFF_CHANNEL(2, 5, 6, AD7193_CH_AIN5P_AIN6M), > + AD719x_DIFF_CHANNEL(3, 7, 8, AD7193_CH_AIN7P_AIN8M), > + AD719x_TEMP_CHANNEL(4, AD7193_CH_TEMP), > + AD719x_SHORTED_CHANNEL(5, 2, AD7193_CH_AIN2P_AIN2M), > + AD719x_CHANNEL(6, 1, AD7193_CH_AIN1), > + AD719x_CHANNEL(7, 2, AD7193_CH_AIN2), > + AD719x_CHANNEL(8, 3, AD7193_CH_AIN3), > + AD719x_CHANNEL(9, 4, AD7193_CH_AIN4), > + AD719x_CHANNEL(10, 5, AD7193_CH_AIN5), > + AD719x_CHANNEL(11, 6, AD7193_CH_AIN6), > + AD719x_CHANNEL(12, 7, AD7193_CH_AIN7), > + AD719x_CHANNEL(13, 8, AD7193_CH_AIN8), > IIO_CHAN_SOFT_TIMESTAMP(14), > }; > > static int ad7192_channels_config(struct iio_dev *indio_dev) > { > struct ad7192_state *st = iio_priv(indio_dev); > - const struct iio_chan_spec *channels; > - struct iio_chan_spec *chan; > - int i; > > switch (st->devid) { > case ID_AD7193: > - channels = ad7193_channels; > + indio_dev->channels = ad7193_channels; > indio_dev->num_channels = ARRAY_SIZE(ad7193_channels); > break; > default: > - channels = ad7192_channels; > + indio_dev->channels = ad7192_channels; > indio_dev->num_channels = ARRAY_SIZE(ad7192_channels); > break; > } > > - chan = devm_kcalloc(indio_dev->dev.parent, indio_dev->num_channels, > - sizeof(*chan), GFP_KERNEL); > - if (!chan) > - return -ENOMEM; > - > - indio_dev->channels = chan; > - > - for (i = 0; i < indio_dev->num_channels; i++) { > - *chan = channels[i]; > - chan->info_mask_shared_by_all |= > - BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY); > - if (chan->type != IIO_TEMP) { > - chan->info_mask_shared_by_type_available |= > - BIT(IIO_CHAN_INFO_SCALE); > - chan->ext_info = ad7192_calibsys_ext_info; > - } > - chan++; > - } > - > return 0; > } >