From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1512C2BA83 for ; Sat, 15 Feb 2020 17:22:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 762D32084E for ; Sat, 15 Feb 2020 17:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581787328; bh=36pnx5QaOICwsMRtkiu/ze9cu2LcJNi0ozOr0fTt05I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=a7B+bME6dxjzhVf0HyG5Qjhlzzk0BVO9Ryh0tdVYhLM8gV2+JIw8sgD+hKOYQK6vp +6S//e0lOsLbTV2VcG9ZWbpDtS2Jqe7y4gTXmU5aYQo9fSz/3nwivzYSRDMyW8oUrd 1Rqdy/U4sQljQlIdL+pXl4ZYQw2c7VfR9QMg9evM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726275AbgBORWI (ORCPT ); Sat, 15 Feb 2020 12:22:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:56158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbgBORWH (ORCPT ); Sat, 15 Feb 2020 12:22:07 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1FAB2083B; Sat, 15 Feb 2020 17:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581787327; bh=36pnx5QaOICwsMRtkiu/ze9cu2LcJNi0ozOr0fTt05I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=13tvJ1yz19ZbOZ/KnIMVnWm3QkWmVa8VjErLak2fPR0W5L2062QzIdEySDTM6au74 Yje+a1zQ4UkCqUkKAJ6ivl0jMsrwFH+IMqayVE5VLf7DxmvI39Zh+E2CmBvRhnfuSg KhAFtHFFfvIbPb7ZAFpT8sTNyVAlyfrd1ZZafl+Y= Date: Sat, 15 Feb 2020 17:22:00 +0000 From: Jonathan Cameron To: David Heidelberg Cc: Dmitry Osipenko , Daniel Baluta , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , linux-iio@vger.kernel.org Subject: Re: [PATCH v5 6/7] iio: light: al3320a implement devm_add_action_or_reset Message-ID: <20200215172200.52ad1ca5@archlinux> In-Reply-To: <20200211191201.1049902-7-david@ixit.cz> References: <20200211191201.1049902-1-david@ixit.cz> <20200211191201.1049902-7-david@ixit.cz> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 11 Feb 2020 20:12:00 +0100 David Heidelberg wrote: > Use devm_add_action_or_reset to automatically disable the device > and allow you to get rid of the remove function entirely. > > Signed-off-by: David Heidelberg Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/light/al3320a.c | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c > index affa4c6c199a..49e73e24fff6 100644 > --- a/drivers/iio/light/al3320a.c > +++ b/drivers/iio/light/al3320a.c > @@ -87,6 +87,13 @@ static int al3320a_set_pwr(struct i2c_client *client, bool pwr) > return i2c_smbus_write_byte_data(data->client, AL3320A_REG_CONFIG, val); > } > > +static void al3320a_set_pwr_off(void *_data) > +{ > + struct al3320a_data *data = _data; > + > + al3320a_set_pwr(data->client, false); > +} > + > static int al3320a_init(struct al3320a_data *data) > { > int ret; > @@ -206,12 +213,14 @@ static int al3320a_probe(struct i2c_client *client, > dev_err(&client->dev, "al3320a chip init failed\n"); > return ret; > } > - return devm_iio_device_register(&client->dev, indio_dev); > -} > > -static int al3320a_remove(struct i2c_client *client) > -{ > - return al3320a_set_pwr(client, false); > + ret = devm_add_action_or_reset(&client->dev, > + al3320a_set_pwr_off, > + data); > + if (ret < 0) > + return ret; > + > + return devm_iio_device_register(&client->dev, indio_dev); > } > > static int __maybe_unused al3320a_suspend(struct device *dev) > @@ -238,7 +247,6 @@ static struct i2c_driver al3320a_driver = { > .pm = &al3320a_pm_ops, > }, > .probe = al3320a_probe, > - .remove = al3320a_remove, > .id_table = al3320a_id, > }; >