From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] iio: imu: adis: update 'adis_data' struct doc-string
Date: Fri, 21 Feb 2020 13:13:59 +0000 [thread overview]
Message-ID: <20200221131359.3b5f54d8@archlinux> (raw)
In-Reply-To: <20200221114943.2056-2-alexandru.ardelean@analog.com>
On Fri, 21 Feb 2020 13:49:42 +0200
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> The doc-string has been neglected over time.
> This change updates it with all the missing info.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Looks good to me. Will pick up in v2.
> ---
> include/linux/iio/imu/adis.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/imu/adis.h b/include/linux/iio/imu/adis.h
> index 0787a3aabd05..11c915b61ae2 100644
> --- a/include/linux/iio/imu/adis.h
> +++ b/include/linux/iio/imu/adis.h
> @@ -43,10 +43,14 @@ struct adis_timeout {
> * @diag_stat_reg: Register address of the DIAG_STAT register
> * @prod_id_reg: Register address of the PROD_ID register
> * @prod_id: Product ID code that should be expected when reading @prod_id_reg
> + * @self_test_mask: Bitmask of supported self-test operations
> * @self_test_reg: Register address to request self test command
> + * @self_test_no_autoclear: True if device's self-test needs clear of ctrl reg
> * @status_error_msgs: Array of error messgaes
> - * @status_error_mask:
> + * @status_error_mask: Bitmask of errors supported by the device
> * @timeouts: Chip specific delays
> + * @enable_irq: Hook for ADIS devices that have a special IRQ enable/disable
> + * @has_paging: True if ADIS device has paged registers
> */
> struct adis_data {
> unsigned int read_delay;
next prev parent reply other threads:[~2020-02-21 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 11:49 [PATCH 1/3] iio: imu: adis: add doc-string for 'adis' struct Alexandru Ardelean
2020-02-21 11:49 ` [PATCH 2/3] iio: imu: adis: update 'adis_data' struct doc-string Alexandru Ardelean
2020-02-21 13:13 ` Jonathan Cameron [this message]
2020-02-21 11:49 ` [PATCH 3/3] iio: imu: adis: add a note better explaining state_lock Alexandru Ardelean
2020-02-21 13:14 ` Jonathan Cameron
2020-02-21 13:11 ` [PATCH 1/3] iio: imu: adis: add doc-string for 'adis' struct Jonathan Cameron
2020-02-21 15:59 ` Ardelean, Alexandru
2020-02-21 16:14 ` Jonathan Cameron
2020-02-21 16:51 ` Ardelean, Alexandru
-- strict thread matches above, loose matches on Subject: below --
2019-10-08 8:02 [PATCH 1/3] iio: imu: adis: add doc-string for `adis` struct Alexandru Ardelean
2019-10-08 8:02 ` [PATCH 2/3] iio: imu: adis: update `adis_data` struct doc-string Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221131359.3b5f54d8@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).