linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
	<pmeerw@pmeerw.net>, <lars@metafoo.de>, <knaack.h@gmx.de>,
	<tglx@linutronix.de>, <alexios.zavras@intel.com>,
	<allison@lohutok.net>, <kstewart@linuxfoundation.org>
Subject: Re: [PATCH] iio: adc: max1118: Use new structure for SPI transfer delays
Date: Sun, 1 Mar 2020 15:49:20 +0000	[thread overview]
Message-ID: <20200301154920.208b7b38@archlinux> (raw)
In-Reply-To: <20200227122515.16628-1-sergiu.cuciurean@analog.com>

On Thu, 27 Feb 2020 14:25:15 +0200
Sergiu Cuciurean <sergiu.cuciurean@analog.com> wrote:

> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/max1118.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/max1118.c b/drivers/iio/adc/max1118.c
> index 3b6f3b9a6c5b..0c5d7aaf6826 100644
> --- a/drivers/iio/adc/max1118.c
> +++ b/drivers/iio/adc/max1118.c
> @@ -71,7 +71,10 @@ static int max1118_read(struct spi_device *spi, int channel)
>  		 */
>  		{
>  			.len = 0,
> -			.delay_usecs = 1,	/* > CNVST Low Time 100 ns */
> +			.delay = {	/* > CNVST Low Time 100 ns */
> +				.value = 1,
> +				.unit = SPI_DELAY_UNIT_USECS
> +			},
>  			.cs_change = 1,
>  		},
>  		/*
> @@ -81,7 +84,10 @@ static int max1118_read(struct spi_device *spi, int channel)
>  		 */
>  		{
>  			.len = 0,
> -			.delay_usecs = 8,
> +			.delay = {
> +				.value = 8,
> +				.unit = SPI_DELAY_UNIT_USECS
> +			},
>  		},
>  		{
>  			.rx_buf = &adc->data,


      reply	other threads:[~2020-03-01 15:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 12:25 [PATCH] iio: adc: max1118: Use new structure for SPI transfer delays Sergiu Cuciurean
2020-03-01 15:49 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200301154920.208b7b38@archlinux \
    --to=jic23@kernel.org \
    --cc=alexios.zavras@intel.com \
    --cc=allison@lohutok.net \
    --cc=knaack.h@gmx.de \
    --cc=kstewart@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=sergiu.cuciurean@analog.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).