* [PATCH] iio: adc: max1118: Use new structure for SPI transfer delays
@ 2020-02-27 12:25 Sergiu Cuciurean
2020-03-01 15:49 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Sergiu Cuciurean @ 2020-02-27 12:25 UTC (permalink / raw)
To: linux-kernel, linux-iio, jic23
Cc: pmeerw, lars, knaack.h, tglx, alexios.zavras, allison, kstewart,
Sergiu Cuciurean
In a recent change to the SPI subsystem [1], a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current
`delay_usecs` with `delay` for this driver.
The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).
[1] commit bebcfd272df6 ("spi: introduce `delay` field for
`spi_transfer` + spi_transfer_delay_exec()")
Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
---
drivers/iio/adc/max1118.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/max1118.c b/drivers/iio/adc/max1118.c
index 3b6f3b9a6c5b..0c5d7aaf6826 100644
--- a/drivers/iio/adc/max1118.c
+++ b/drivers/iio/adc/max1118.c
@@ -71,7 +71,10 @@ static int max1118_read(struct spi_device *spi, int channel)
*/
{
.len = 0,
- .delay_usecs = 1, /* > CNVST Low Time 100 ns */
+ .delay = { /* > CNVST Low Time 100 ns */
+ .value = 1,
+ .unit = SPI_DELAY_UNIT_USECS
+ },
.cs_change = 1,
},
/*
@@ -81,7 +84,10 @@ static int max1118_read(struct spi_device *spi, int channel)
*/
{
.len = 0,
- .delay_usecs = 8,
+ .delay = {
+ .value = 8,
+ .unit = SPI_DELAY_UNIT_USECS
+ },
},
{
.rx_buf = &adc->data,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: max1118: Use new structure for SPI transfer delays
2020-02-27 12:25 [PATCH] iio: adc: max1118: Use new structure for SPI transfer delays Sergiu Cuciurean
@ 2020-03-01 15:49 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-03-01 15:49 UTC (permalink / raw)
To: Sergiu Cuciurean
Cc: linux-kernel, linux-iio, pmeerw, lars, knaack.h, tglx,
alexios.zavras, allison, kstewart
On Thu, 27 Feb 2020 14:25:15 +0200
Sergiu Cuciurean <sergiu.cuciurean@analog.com> wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
>
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
>
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
>
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/max1118.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/max1118.c b/drivers/iio/adc/max1118.c
> index 3b6f3b9a6c5b..0c5d7aaf6826 100644
> --- a/drivers/iio/adc/max1118.c
> +++ b/drivers/iio/adc/max1118.c
> @@ -71,7 +71,10 @@ static int max1118_read(struct spi_device *spi, int channel)
> */
> {
> .len = 0,
> - .delay_usecs = 1, /* > CNVST Low Time 100 ns */
> + .delay = { /* > CNVST Low Time 100 ns */
> + .value = 1,
> + .unit = SPI_DELAY_UNIT_USECS
> + },
> .cs_change = 1,
> },
> /*
> @@ -81,7 +84,10 @@ static int max1118_read(struct spi_device *spi, int channel)
> */
> {
> .len = 0,
> - .delay_usecs = 8,
> + .delay = {
> + .value = 8,
> + .unit = SPI_DELAY_UNIT_USECS
> + },
> },
> {
> .rx_buf = &adc->data,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-01 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-27 12:25 [PATCH] iio: adc: max1118: Use new structure for SPI transfer delays Sergiu Cuciurean
2020-03-01 15:49 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).