From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71237C10DCE for ; Sun, 15 Mar 2020 12:26:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AE6D205ED for ; Sun, 15 Mar 2020 12:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584275175; bh=UrIn4ILa0UYttZMyycJls8xFcjIhgvcUoCuGsIIHmLo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=XBmbSsjQQD1F564k2wxAw7afW+X2RxOpTirKf7Q4wkJrgWLVFV/KT29x4gXE0K9Du oWFQdqZeDeMOzKdpXQO0mXipm5wGxTgEntjkWCUzxlpHAaALNPw61AqF/lTV82ihyF m5budnYLBOTYyU/dspCx2s0UJw34Cgt6/RzUzR5M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728471AbgCOM0O (ORCPT ); Sun, 15 Mar 2020 08:26:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:36342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728469AbgCOM0O (ORCPT ); Sun, 15 Mar 2020 08:26:14 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E596205C9; Sun, 15 Mar 2020 12:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584275173; bh=UrIn4ILa0UYttZMyycJls8xFcjIhgvcUoCuGsIIHmLo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cUFNhNpnhMiPcsx7UKqlxzGfTYHplDPbBiljyjz2fig2ko1EtVWFfGDc4/SPf+nq/ vCMmqWa14m+uatzmIAJcn1A/9I+1q1SjtDBPeUIi0D/c32p+XMfRIq3Ax6XXSjYvvo hM1O6JBGF8Sc6DlrGoQ+/KpY+fLq6do2/8SMsNak= Date: Sun, 15 Mar 2020 12:26:09 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, Denis Ciocca Subject: Re: [PATCH v2 1/8] iio: light: st_uvis25: Drop unneeded casting when print error code Message-ID: <20200315122609.31ab6673@archlinux> In-Reply-To: <20200313104955.30423-1-andriy.shevchenko@linux.intel.com> References: <20200313104955.30423-1-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 13 Mar 2020 12:49:48 +0200 Andy Shevchenko wrote: > Explicit casting in printf() usually shows that something is not okay. > Here, we really don't need it by providing correct specifier. > > Signed-off-by: Andy Shevchenko Applied to the togreg branch of iio.git. thanks, Jonathan > --- > v2: no change > drivers/iio/light/st_uvis25_i2c.c | 4 ++-- > drivers/iio/light/st_uvis25_spi.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/light/st_uvis25_i2c.c b/drivers/iio/light/st_uvis25_i2c.c > index 4889bbeb0c73..400724069d19 100644 > --- a/drivers/iio/light/st_uvis25_i2c.c > +++ b/drivers/iio/light/st_uvis25_i2c.c > @@ -31,8 +31,8 @@ static int st_uvis25_i2c_probe(struct i2c_client *client, > > regmap = devm_regmap_init_i2c(client, &st_uvis25_i2c_regmap_config); > if (IS_ERR(regmap)) { > - dev_err(&client->dev, "Failed to register i2c regmap %d\n", > - (int)PTR_ERR(regmap)); > + dev_err(&client->dev, "Failed to register i2c regmap %ld\n", > + PTR_ERR(regmap)); > return PTR_ERR(regmap); > } > > diff --git a/drivers/iio/light/st_uvis25_spi.c b/drivers/iio/light/st_uvis25_spi.c > index a9ceae4f58b3..cd3761a3ee3f 100644 > --- a/drivers/iio/light/st_uvis25_spi.c > +++ b/drivers/iio/light/st_uvis25_spi.c > @@ -31,8 +31,8 @@ static int st_uvis25_spi_probe(struct spi_device *spi) > > regmap = devm_regmap_init_spi(spi, &st_uvis25_spi_regmap_config); > if (IS_ERR(regmap)) { > - dev_err(&spi->dev, "Failed to register spi regmap %d\n", > - (int)PTR_ERR(regmap)); > + dev_err(&spi->dev, "Failed to register spi regmap %ld\n", > + PTR_ERR(regmap)); > return PTR_ERR(regmap); > } >