From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A20EC10DCE for ; Sun, 15 Mar 2020 12:41:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1ED96206B1 for ; Sun, 15 Mar 2020 12:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584276064; bh=8VVQTTInwJ8TvnSYj2kxUXuQo3fb1NJItUbhAdAiMNk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=y+59CoKa6a/2ygcgjXssRYkbxjbe5issUeZ5zrsaUeLV7zfcyJax7Ge0yM6trzS9V XloSNjewphfTorKVfuD5QFqmXZLPNhQ5ssgPIDaF6RbENKYsxU8BLasa6JPfurxOpK DeFdQNW+Rljqf3rKC3qHfW92DAWjg+ZLclmioqqw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728510AbgCOMlD (ORCPT ); Sun, 15 Mar 2020 08:41:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:38508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728467AbgCOMlD (ORCPT ); Sun, 15 Mar 2020 08:41:03 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C50BF20674; Sun, 15 Mar 2020 12:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584276062; bh=8VVQTTInwJ8TvnSYj2kxUXuQo3fb1NJItUbhAdAiMNk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BaY8dpbCqgaqPh/uVO+E2+KThpEQyNgHnUc/n74UZvN1PDl65QtNVwnLQBke40YYM b9M3tkzMx6pLIoXDAxnv63jiyCrk1YmuDS9t6bPXSe8aYTw0cukr8snMDuK8S67kx8 tGFGY4Aq36Rq7vdxeY3c3e4G/TrEPucEeJMsTrLA= Date: Sun, 15 Mar 2020 12:40:58 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, Denis Ciocca Subject: Re: [PATCH v2 5/8] iio: st_sensors: Join string literals back Message-ID: <20200315124058.36fbef4f@archlinux> In-Reply-To: <20200313104955.30423-5-andriy.shevchenko@linux.intel.com> References: <20200313104955.30423-1-andriy.shevchenko@linux.intel.com> <20200313104955.30423-5-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 13 Mar 2020 12:49:52 +0200 Andy Shevchenko wrote: > For easy grepping on debug purposes join string literals back in > the messages. > > No functional change. > > Signed-off-by: Andy Shevchenko Applied. Thanks, Jonathan > --- > v2: no change > drivers/iio/common/st_sensors/st_sensors_core.c | 3 +-- > drivers/iio/common/st_sensors/st_sensors_trigger.c | 13 ++++--------- > 2 files changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c > index 804a9068e687..2e42838ca4f4 100644 > --- a/drivers/iio/common/st_sensors/st_sensors_core.c > +++ b/drivers/iio/common/st_sensors/st_sensors_core.c > @@ -277,8 +277,7 @@ static int st_sensors_set_drdy_int_pin(struct iio_dev *indio_dev, > !sdata->sensor_settings->drdy_irq.int2.addr) { > if (pdata->drdy_int_pin) > dev_info(&indio_dev->dev, > - "DRDY on pin INT%d specified, but sensor " > - "does not support interrupts\n", > + "DRDY on pin INT%d specified, but sensor does not support interrupts\n", > pdata->drdy_int_pin); > return 0; > } > diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c > index e817537cdfb5..0507283bd4c1 100644 > --- a/drivers/iio/common/st_sensors/st_sensors_trigger.c > +++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c > @@ -44,8 +44,7 @@ static int st_sensors_new_samples_available(struct iio_dev *indio_dev, > sdata->sensor_settings->drdy_irq.stat_drdy.addr, > &status); > if (ret < 0) { > - dev_err(sdata->dev, > - "error checking samples available\n"); > + dev_err(sdata->dev, "error checking samples available\n"); > return ret; > } > > @@ -148,9 +147,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev, > case IRQF_TRIGGER_LOW: > if (!sdata->sensor_settings->drdy_irq.addr_ihl) { > dev_err(&indio_dev->dev, > - "falling/low specified for IRQ " > - "but hardware supports only rising/high: " > - "will request rising/high\n"); > + "falling/low specified for IRQ but hardware supports only rising/high: will request rising/high\n"); > if (irq_trig == IRQF_TRIGGER_FALLING) > irq_trig = IRQF_TRIGGER_RISING; > if (irq_trig == IRQF_TRIGGER_LOW) > @@ -163,8 +160,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev, > if (err < 0) > goto iio_trigger_free; > dev_info(&indio_dev->dev, > - "interrupts on the falling edge or " > - "active low level\n"); > + "interrupts on the falling edge or active low level\n"); > } > break; > case IRQF_TRIGGER_RISING: > @@ -178,8 +174,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev, > default: > /* This is the most preferred mode, if possible */ > dev_err(&indio_dev->dev, > - "unsupported IRQ trigger specified (%lx), enforce " > - "rising edge\n", irq_trig); > + "unsupported IRQ trigger specified (%lx), enforce rising edge\n", irq_trig); > irq_trig = IRQF_TRIGGER_RISING; > } >