From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC13C10DCE for ; Wed, 18 Mar 2020 15:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5590020775 for ; Wed, 18 Mar 2020 15:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584544724; bh=F859fJ/sB++ZOHd4fXzaKvxObov5lRC7ze365VuxEY8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sVCl0PbXYLXhMH6hl0tXb3ImkYCTyKUhcn/+CefrwR7fcCN8fItkJ2NxxddKyaWcV 66mXext0lxJNUexs+02BAEnQqUFZp6K9irYzlJp7/eGQ5S6+omkCdI8DUsFU3fvPEw 8pZEpWovrLMDtzpE81XSraee9F5uIR71q6MxMle4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727052AbgCRPSn (ORCPT ); Wed, 18 Mar 2020 11:18:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:41416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726619AbgCRPSn (ORCPT ); Wed, 18 Mar 2020 11:18:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D05820770; Wed, 18 Mar 2020 15:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584544721; bh=F859fJ/sB++ZOHd4fXzaKvxObov5lRC7ze365VuxEY8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AwWNdmn5mmGh0ZvImbWDnv3Hkh70cweWqZaVOkg+dslhUTa55JL2rf0tQORnhleYi qz2izubutup4j2ksBypOptievKIVcVxFa20LtuCZDMOLGKMCpeJDtIt1JKOL8z74DY SN9yMlbXqTw9YtaLn87CzubEts5qdi7XUuzQLvcM= Date: Wed, 18 Mar 2020 16:18:39 +0100 From: Greg KH To: DEEPAK VARMA Cc: outreachy-kernel@googlegroups.com, daniel.baluta@gmail.com, kieran.bingham@ideasonboard.com, lars@metafoo.de, Michael.Hennerich@analog.com, stefan.popa@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org Subject: Re: [PATCH 1/2] staging: iio: adc: ad7192: Reformat lines crossing 80 columns Message-ID: <20200318151839.GA2862853@kroah.com> References: <50419988d636c90511a07da256c91aa3b3e33bff.1584505215.git.mh12gx2825@gmail.com> <20200318060004.GA1594471@kroah.com> <20200318151244.GB22841@deeUbuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318151244.GB22841@deeUbuntu> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, Mar 18, 2020 at 08:42:45PM +0530, DEEPAK VARMA wrote: > On Wed, Mar 18, 2020 at 07:00:04AM +0100, Greg KH wrote: > > On Wed, Mar 18, 2020 at 09:56:59AM +0530, Deepak R Varma wrote: > > > Macro arguments are computed at the time of macro invocation. This makes > > > the lines cross 80 column width. Add variables to perform the > > > calculations before hand and use these new variable in the macro calls > > > instead. > > > > > > Also re-indent enum members to address checkpatch warning / check messages. > > > > When you say "also" in a changelog description, that's a huge hint the > > patch needs to be broken up. > > > > And that is what needs to happen here. > > > > > > > > Signed-off-by: Deepak R Varma > > > --- > > > drivers/staging/iio/adc/ad7192.c | 15 ++++++++------- > > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > > > index bf3e2a9cc07f..0265f6607d75 100644 > > > --- a/drivers/staging/iio/adc/ad7192.c > > > +++ b/drivers/staging/iio/adc/ad7192.c > > > @@ -156,8 +156,8 @@ > > > */ > > > > > > enum { > > > - AD7192_SYSCALIB_ZERO_SCALE, > > > - AD7192_SYSCALIB_FULL_SCALE, > > > + AD7192_SYSCALIB_ZERO_SCALE, > > > + AD7192_SYSCALIB_FULL_SCALE, > > > > Because this has nothing to do with the subject, please make it a > > separate patch. > > > > Okay. Got your point. I was thinking since this is a clean up patch I can include both > the changes for the same file in a single patch. No problem; I will > correct and send in a v2. >From my patch bot which would have normally triggered on this patch had it not been part of the outrechy project: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause.