[PATCH 0/2] Maxim MAX1241 driver, v2

Alexandru Lazar
2020-03-18T20:24:20Z

Hello again,

Here's version 2 of a patch series which adds support for the Maxim
MAX1241, a 12-bit, single-channel, SPI-connected ADC. The previous
version is here:

https://lore.kernel.org/linux-iio/20200317201710.23180-1-alazar@startmail.com/

I've integrated pretty much all of the suggestions I got here, and fixed
the issues that you all pointed out (thanks again! Did I say thanks
lately? Thanks!!!). A short list of the changes is at the end of this
message. checkpatch.pl is happy, it just warns me about the MAINTAINERS
file, where I don't think an entry is necessary. dt_bindings_check is
happy, too.

The only suggestion that I haven't incorporated is adding max1240 to the
list of compatible devices. I've thought about it, but there are
timing-related differences between the two devices, so simply validating
what my machine sends wouldn't be definitive. I think it would be
disingenious to claim compatibility under these circumstances. I do plan
to get a 1240 asap, anyway, and with any luck my patch would just update
the compat string.

Now, here's what I changed:

* Removed useeless header includes

* Dropped needlessly verbose stuff in _read and _probe functions

* Dropped useless GPL notice

* Lowered log level of shdn pin status in probe function, now it's
dev_dbg

* Added proper error checking for the GPIO shutdown pin

* remove now always returns zero (man, I've been wrong about this for
*years* now...)

* Added regulator disable action, cleanup is now handled via devm

* Drop delay_usecs, use delay.value, delay.unit

* Drop config_of, of_match_ptr call

* Dropped IIO_BUFFER, IIO_TRIGGERED_BUFFER dependencies, set SPI_MASTER
as dependency, fix indenting.

* DT binding: use correct id, add reg description (looks pretty
standard), dropped spi-max-frequency, fixed dt_binding_check
complaints (oops!)

Thanks!

Alex

Alexandru Lazar (2):
iio: adc: Add MAX1241 driver
dt-bindings: iio: adc: Add MAX1241 device tree bindings in
documentation

.../bindings/iio/adc/maxim,max1241.yaml | 62 ++++++
drivers/iio/adc/Kconfig | 10 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/max1241.c | 206 ++++++++++++++++++
4 files changed, 279 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
create mode 100644 drivers/iio/adc/max1241.c

--
2.25.1