From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEFFBC4332B for ; Sun, 22 Mar 2020 17:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FCA9206C3 for ; Sun, 22 Mar 2020 17:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584899553; bh=E4tkfsLC2npwliTDR8mBLrea9DerZNIIDxFJTaOlD0k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=BK2R9FgaQyr27I/XxJzVglG82NgBoHRTPJL4frZ/pjREKRcOHhOvNGYuiupbAbqhl F13ulXtREstCbBS6N1gL5XZiCfRg8fi7KeV1lIqbz/+WUtBRcdSbP+e/yDJ8yLyQNW hu5rApt0nwGgylOgjWG8t0YHSHegX+Tl6qAiv3Q0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726137AbgCVRwd (ORCPT ); Sun, 22 Mar 2020 13:52:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:34418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbgCVRwd (ORCPT ); Sun, 22 Mar 2020 13:52:33 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 24B63206C3; Sun, 22 Mar 2020 17:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584899551; bh=E4tkfsLC2npwliTDR8mBLrea9DerZNIIDxFJTaOlD0k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xFXRyqaXvjCustqER/6dHYlCtRtCClXD9avWVmoAzhiR8JaxhRGNOykk4cBwEzcOR RNcYWwpEgqSKS3s5lkvcdMnvJVQWJ6Xe4GCgEMEHekIhMFp2AcoyIPml19SAPRRlKl 6YbNPlIbCICXOejuiwNTmgQ3MnkS7q/Fz6sJzIfE= Date: Sun, 22 Mar 2020 17:52:27 +0000 From: Jonathan Cameron To: Rohit Sarkar Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, dragos.bogdan@analog.com Subject: Re: [PATCH v7] iio: adc: max1363: replace uses of mlock Message-ID: <20200322175227.1623048e@archlinux> In-Reply-To: <5e766058.1c69fb81.a65ff.d2eb@mx.google.com> References: <5e6e522d.1c69fb81.10f54.f95c@mx.google.com> <5e766058.1c69fb81.a65ff.d2eb@mx.google.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 22 Mar 2020 00:13:32 +0530 Rohit Sarkar wrote: > Hey, > Does this look fine? Wondering if this was missed during review > Thanks, > Rohit Nope just a busy week. + I review from latest emails backwards (and almost always get through everything). Questions have a habit of being resolved quicker that way around ;) Jonathan > > On Sun, Mar 15, 2020 at 09:34:58PM +0530, Rohit Sarkar wrote: > > Replace usage indio_dev's mlock with either local lock or > > iio_device_claim_direct_mode. > > > > Signed-off-by: Rohit Sarkar > > --- > > Changelog v6 -> v7 > > * Fix failure handling logic > > > > Changelog v5 -> v6 > > * Minor failure handling fixes > > > > Changelog v4 -> v5 > > * Use local lock too at places where driver state needs to be protected. > > > > Changelog v3 -> v4 > > * Fix indentation > > > > Changelog v2 -> v3 > > * use iio_device_claim_direct when switching modes > > * replace mlock usage in max1363_write_event_config > > > > Changelog v1 -> v2 > > * Fix indentation > > > > drivers/iio/adc/max1363.c | 37 ++++++++++++++++++++++++++++--------- > > 1 file changed, 28 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c > > index 5c2cc61b666e..12d72bf3f12a 100644 > > --- a/drivers/iio/adc/max1363.c > > +++ b/drivers/iio/adc/max1363.c > > @@ -150,6 +150,7 @@ struct max1363_chip_info { > > * @current_mode: the scan mode of this chip > > * @requestedmask: a valid requested set of channels > > * @reg: supply regulator > > + * @lock lock to ensure state is consistent > > * @monitor_on: whether monitor mode is enabled > > * @monitor_speed: parameter corresponding to device monitor speed setting > > * @mask_high: bitmask for enabled high thresholds > > @@ -169,6 +170,7 @@ struct max1363_state { > > const struct max1363_mode *current_mode; > > u32 requestedmask; > > struct regulator *reg; > > + struct mutex lock; > > > > /* Using monitor modes and buffer at the same time is > > currently not supported */ > > @@ -364,7 +366,13 @@ static int max1363_read_single_chan(struct iio_dev *indio_dev, > > struct max1363_state *st = iio_priv(indio_dev); > > struct i2c_client *client = st->client; > > > > - mutex_lock(&indio_dev->mlock); > > + ret = iio_device_claim_direct_mode(indio_dev); > > + if (ret) > > + return ret; > > + mutex_lock(&st->lock); > > + > > + if (ret < 0) > > + goto error_ret; > > /* > > * If monitor mode is enabled, the method for reading a single > > * channel will have to be rather different and has not yet > > @@ -372,7 +380,7 @@ static int max1363_read_single_chan(struct iio_dev *indio_dev, > > * > > * Also, cannot read directly if buffered capture enabled. > > */ > > - if (st->monitor_on || iio_buffer_enabled(indio_dev)) { > > + if (st->monitor_on) { > > ret = -EBUSY; > > goto error_ret; > > } > > @@ -404,8 +412,10 @@ static int max1363_read_single_chan(struct iio_dev *indio_dev, > > data = rxbuf[0]; > > } > > *val = data; > > + > > error_ret: > > - mutex_unlock(&indio_dev->mlock); > > + mutex_unlock(&st->lock); > > + iio_device_release_direct_mode(indio_dev); > > return ret; > > > > } > > @@ -705,9 +715,9 @@ static ssize_t max1363_monitor_store_freq(struct device *dev, > > if (!found) > > return -EINVAL; > > > > - mutex_lock(&indio_dev->mlock); > > + mutex_lock(&st->lock); > > st->monitor_speed = i; > > - mutex_unlock(&indio_dev->mlock); > > + mutex_unlock(&st->lock); > > > > return 0; > > } > > @@ -810,12 +820,12 @@ static int max1363_read_event_config(struct iio_dev *indio_dev, > > int val; > > int number = chan->channel; > > > > - mutex_lock(&indio_dev->mlock); > > + mutex_lock(&st->lock); > > if (dir == IIO_EV_DIR_FALLING) > > val = (1 << number) & st->mask_low; > > else > > val = (1 << number) & st->mask_high; > > - mutex_unlock(&indio_dev->mlock); > > + mutex_unlock(&st->lock); > > > > return val; > > } > > @@ -962,7 +972,14 @@ static int max1363_write_event_config(struct iio_dev *indio_dev, > > u16 unifiedmask; > > int number = chan->channel; > > > > - mutex_lock(&indio_dev->mlock); > > + ret = iio_device_claim_direct_mode(indio_dev); > > + if (ret) > > + return ret; > > + mutex_lock(&st->lock); > > + > > + if (ret < 0) > > + goto error_ret; > > + > > unifiedmask = st->mask_low | st->mask_high; > > if (dir == IIO_EV_DIR_FALLING) { > > > > @@ -989,7 +1006,8 @@ static int max1363_write_event_config(struct iio_dev *indio_dev, > > > > max1363_monitor_mode_update(st, !!(st->mask_high | st->mask_low)); > > error_ret: > > - mutex_unlock(&indio_dev->mlock); > > + mutex_unlock(&st->lock); > > + iio_device_release_direct_mode(indio_dev); > > > > return ret; > > } > > @@ -1587,6 +1605,7 @@ static int max1363_probe(struct i2c_client *client, > > > > st = iio_priv(indio_dev); > > > > + mutex_init(&st->lock); > > st->reg = devm_regulator_get(&client->dev, "vcc"); > > if (IS_ERR(st->reg)) { > > ret = PTR_ERR(st->reg); > > -- > > 2.23.0.385.gbc12974a89 > >