From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AECB8C3F2CD for ; Mon, 23 Mar 2020 15:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 787342077D for ; Mon, 23 Mar 2020 15:17:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dwq6Y3oh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727024AbgCWPRU (ORCPT ); Mon, 23 Mar 2020 11:17:20 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:38318 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbgCWPRT (ORCPT ); Mon, 23 Mar 2020 11:17:19 -0400 Received: by mail-pg1-f196.google.com with SMTP id x7so7349800pgh.5 for ; Mon, 23 Mar 2020 08:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Y5WxcqTugnAo9X+DA9YOBgJCfSv0O7b15VIBu8XZa4A=; b=dwq6Y3oh/SSqSVYxAanGu7uxp0yDphGU1TNq+c4SKtXqlb9zuvHXCaH0gOHVf+5owJ +P2Pu9mYk41+q9pQeY0ykRWhajyOPs3Brrxy+so9T94idHN72XXDNXUEUsaEKpfWaZv6 vXzcQmMJelkP9IhglFwx6U1FyWlfxLLQLk4n+rdMmAmGPeUIWdsPEsshDHuXFHrb30pf bWFyUZLg0RGBpwL+pnvpXAPtVFCrdoB/eRXRGKJPUM8TxGIO4wWHes/GEVprU7BTahs7 p+u4Vv8vxKVlnacXkB5mR7RxVqCxF5Y7aHmMVqykJpLC1piO3Ffh4bU1tZIe1/WLMlUu 9M2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Y5WxcqTugnAo9X+DA9YOBgJCfSv0O7b15VIBu8XZa4A=; b=DF+SnC6BpIMz5rnAagLSU5aaGAzPE8tED1rCFRIfS5nNbZEp2jGmoEAFZgTrBPMpD3 2Hh/2yoPdgwqVCLuxm0mUiJvfHlUHqAgoDzF3dU7vFK5hzIXw+L3P6qzZwDtgFRR7kfs i6vi5GWqVe1Th5rKOVG7v6aM+5INl/xODSZHCe/j9LCfMI1so3uYgoBnCVE1w3uoiGvT Zr0SB2SYDc5iRRUbZrsyR4Gd8VKi7GcUfHXlUu7fPyYW/0HERlZLWnm+yQMWSb2tYTVn UcCVh1wF4S1eRP9jeBLOrI1ztAN/QJM756G0paGwSNCrqNA3uld3k88uRGB07aW/aN7h uQAA== X-Gm-Message-State: ANhLgQ1HdR3NUYnldwpWWjhc3yOZR9ZU4dEolF4JL1aMGsFWTBlGKvsl O3vYxrBd2ZIwVB3IJEUcOMQ= X-Google-Smtp-Source: ADFU+vsLgUSOlKYleVFj8hshgXTaxjeig+FDVpdTlRGs2VtJLisA5pe5cnBHT5G8sxHrpr2RoXcIeg== X-Received: by 2002:a63:8b41:: with SMTP id j62mr21702334pge.18.1584976638849; Mon, 23 Mar 2020 08:17:18 -0700 (PDT) Received: from deeUbuntu ([103.240.207.191]) by smtp.gmail.com with ESMTPSA id i187sm13502225pfg.33.2020.03.23.08.17.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Mar 2020 08:17:18 -0700 (PDT) Date: Mon, 23 Mar 2020 20:47:12 +0530 From: DEEPAK VARMA To: Andy Shevchenko Cc: outreachy-kernel@googlegroups.com, Greg Kroah-Hartman , Daniel Baluta , kieran.bingham@ideasonboard.com, Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald , linux-iio Subject: Re: [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization Message-ID: <20200323151710.GA22110@deeUbuntu> References: <20200322185350.GA12377@deeUbuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, Mar 23, 2020 at 01:35:58AM +0200, Andy Shevchenko wrote: > On Sun, Mar 22, 2020 at 8:54 PM Deepak R Varma wrote: > > > > Reformat pointer initialization to make it more readable as per the > > coding standards. Problem detected by checkpatch. > > > - struct imgu_v4l2_subdev *imgu_sd = > > - container_of(ctrl->handler, struct imgu_v4l2_subdev, ctrl_handler); > > + struct imgu_v4l2_subdev *imgu_sd = container_of(ctrl->handler, > > + struct imgu_v4l2_subdev, > > + ctrl_handler); > > I'm sorry I don't see benefit of this change, actually an opposite. Hello Andy, Thank you for your comment. To me, it helps quickly and clearly spot *imgu_sd. Also the initialization looks more structured. But that's just me. I will wait to see if anyone else wants to share their thoughts, and then circle back to you on next steps. Is that fine? Deepak. > > -- > With Best Regards, > Andy Shevchenko