From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lars@metafoo.de>
Subject: Re: [PATCH] iio: buffer: drop left-over 'stufftoread' field
Date: Sun, 29 Mar 2020 10:40:01 +0100 [thread overview]
Message-ID: <20200329104001.6b62b4ab@archlinux> (raw)
In-Reply-To: <20200328163421.69784-1-alexandru.ardelean@analog.com>
On Sat, 28 Mar 2020 18:34:21 +0200
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> This seems like a left-over from a7348347ba8a4 ("staging:iio: Add polling
> of events on the ring access chrdev.").
>
> Then it was moved into the sca3000 driver around 9dd4694dafbd8 ("iio:
> staging: sca3000: hide stufftoread logic"), and that one seemed to be the
> only user of this.
>
> Then it eventually was no longer used after 152a6a884ae1
> ("staging:iio:accel:sca3000 move to hybrid hard / soft buffer design.")
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Oops.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> include/linux/iio/buffer_impl.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/iio/buffer_impl.h b/include/linux/iio/buffer_impl.h
> index a4d2d8061ef6..1e7edf6bed96 100644
> --- a/include/linux/iio/buffer_impl.h
> +++ b/include/linux/iio/buffer_impl.h
> @@ -115,9 +115,6 @@ struct iio_buffer {
> */
> struct attribute_group scan_el_group;
>
> - /* @stufftoread: Flag to indicate new data. */
> - bool stufftoread;
> -
> /* @attrs: Standard attributes of the buffer. */
> const struct attribute **attrs;
>
prev parent reply other threads:[~2020-03-29 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 16:34 [PATCH] iio: buffer: drop left-over 'stufftoread' field Alexandru Ardelean
2020-03-29 9:40 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200329104001.6b62b4ab@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).