From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37233C2BA15 for ; Sat, 4 Apr 2020 15:38:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A12B206F8 for ; Sat, 4 Apr 2020 15:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586014687; bh=016bPs53uTJoZ4UjX+VEtpi7tnVVWRCyC75+6CHq38w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=NQgdwVhx05R0SKkRi9pOZMHorTn55N17k166QPT3XHgKotd8jtn3UZrAYwVk4TzCJ CFDZdX3ZmCbM62U05KeNzBibn0QnmmJUIY3mVeeeHJtSf+R7+wMlDE85Gby0005EVd wfGdx1DCN9el6HGtxOl9EIxKdOEipTjOWJWOmXAw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726197AbgDDPiG (ORCPT ); Sat, 4 Apr 2020 11:38:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:38666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgDDPiG (ORCPT ); Sat, 4 Apr 2020 11:38:06 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C70F920644; Sat, 4 Apr 2020 15:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586014685; bh=016bPs53uTJoZ4UjX+VEtpi7tnVVWRCyC75+6CHq38w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZWeaYyIdTDQa8MkeF9462u1JpofbFOAicflu7vgoIS9fohUlXtcSFSSPHXLmm1cIP +ue7vUWjxi9UfYxgxVireP7uMbnD4Ik1/hWXXy5eMi6beEF6WR4WQXPzQjzvXoUCHF lv3FHgse9jQ5xGQmaT4katvuOPSyuT2I5/6Blna4= Date: Sat, 4 Apr 2020 16:38:01 +0100 From: Jonathan Cameron To: Jimmy Assarsson Cc: linux-iio@vger.kernel.org, Lorenzo Bianconi , Andy Shevchenko Subject: Re: [PATCH v2 2/2] iio: imu: st_lsm6dsx: Add sensor hub device LIS3MDL Message-ID: <20200404163801.43e3b094@archlinux> In-Reply-To: <20200329104240.230b05a9@archlinux> References: <20200328184519.2302703-1-jimmyassarsson@gmail.com> <20200329104240.230b05a9@archlinux> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 29 Mar 2020 10:42:40 +0100 Jonathan Cameron wrote: > On Sat, 28 Mar 2020 19:45:19 +0100 > Jimmy Assarsson wrote: > > > Add LIS3MDL register map to sensor hub device table. > > Tested with LSM6DSM. > > > > Signed-off-by: Jimmy Assarsson > > Please always repost the entire series. On this occasion I can find > patch 1 but sometimes it's not so easy :) > > Looks fine to me, but lets' leave it on list for a while longer to > see if others wish to comment. > Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > --- > > Changes in v2: > > - Use ST_SENSORS_DEFAULT_WAI_ADDRESS > > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c | 64 ++++++++++++++++++++ > > 1 file changed, 64 insertions(+) > > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c > > index 95ddd19d1aa7..3b983e0cc5ce 100644 > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c > > @@ -28,6 +28,7 @@ > > #include > > #include > > > > +#include > > #include "st_lsm6dsx.h" > > > > #define ST_LSM6DSX_SLV_ADDR(n, base) ((base) + (n) * 3) > > @@ -88,6 +89,69 @@ static const struct st_lsm6dsx_ext_dev_settings st_lsm6dsx_ext_dev_table[] = { > > .len = 6, > > }, > > }, > > + /* LIS3MDL */ > > + { > > + .i2c_addr = { 0x1e }, > > + .wai = { > > + .addr = ST_SENSORS_DEFAULT_WAI_ADDRESS, > > + .val = 0x3d, > > + }, > > + .id = ST_LSM6DSX_ID_MAGN, > > + .odr_table = { > > + .reg = { > > + .addr = 0x20, > > + .mask = GENMASK(4, 2), > > + }, > > + .odr_avl[0] = { 1000, 0x0 }, > > + .odr_avl[1] = { 2000, 0x1 }, > > + .odr_avl[2] = { 3000, 0x2 }, > > + .odr_avl[3] = { 5000, 0x3 }, > > + .odr_avl[4] = { 10000, 0x4 }, > > + .odr_avl[5] = { 20000, 0x5 }, > > + .odr_avl[6] = { 40000, 0x6 }, > > + .odr_avl[7] = { 80000, 0x7 }, > > + .odr_len = 8, > > + }, > > + .fs_table = { > > + .reg = { > > + .addr = 0x21, > > + .mask = GENMASK(6, 5), > > + }, > > + .fs_avl[0] = { > > + .gain = 146, > > + .val = 0x00, > > + }, /* 4000 uG/LSB */ > > + .fs_avl[1] = { > > + .gain = 292, > > + .val = 0x01, > > + }, /* 8000 uG/LSB */ > > + .fs_avl[2] = { > > + .gain = 438, > > + .val = 0x02, > > + }, /* 12000 uG/LSB */ > > + .fs_avl[3] = { > > + .gain = 584, > > + .val = 0x03, > > + }, /* 16000 uG/LSB */ > > + .fs_len = 4, > > + }, > > + .pwr_table = { > > + .reg = { > > + .addr = 0x22, > > + .mask = GENMASK(1, 0), > > + }, > > + .off_val = 0x2, > > + .on_val = 0x0, > > + }, > > + .bdu = { > > + .addr = 0x24, > > + .mask = BIT(6), > > + }, > > + .out = { > > + .addr = 0x28, > > + .len = 6, > > + }, > > + }, > > }; > > > > static void st_lsm6dsx_shub_wait_complete(struct st_lsm6dsx_hw *hw) >