From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F0FC2D0F4 for ; Sun, 5 Apr 2020 11:59:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72AD7206F8 for ; Sun, 5 Apr 2020 11:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586087961; bh=+wGxOfzb3Kic1eA+umuFEn0WHWrxSh5LLIkTr9+zSD8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=eieo/x7ahVj11qnCfcuymiO4lSnrm5cMUvF5aSTEjU1ypPIdM9+Ioowgb1ck7YHZG AxgJKGygrqdL8kcE/Cu7BAZ1+azre1zVRMR4oevXIYJALcp4/wHQ8TnPHgDUMGCMuK 2xbYt6wv8pG5r+1gKKVqjdjPmhNx3jXmW1BQJmsw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726473AbgDEL7V (ORCPT ); Sun, 5 Apr 2020 07:59:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:35526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726410AbgDEL7U (ORCPT ); Sun, 5 Apr 2020 07:59:20 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B68D20675; Sun, 5 Apr 2020 11:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586087960; bh=+wGxOfzb3Kic1eA+umuFEn0WHWrxSh5LLIkTr9+zSD8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cg6XDwMrmYu47NlK2zZ+5P9zLL9+d4rZi7FJ05z977umTVaqvrvnTxYQufRmZSRR/ yJBZD/PKp35eOfg5LIs0dxC/XZXMTHaNI243QJAnxQoDawjH36M+qyziCVX8erx3XO q5otDKTjoMpc2+0hPnLPe0Qz/x/2M3DSNSmb7Dq8= Date: Sun, 5 Apr 2020 12:59:16 +0100 From: Jonathan Cameron To: Lars-Peter Clausen Cc: Hartmut Knaack , Peter Meerwald-Stadler , Alexandru Ardelean , linux-iio@vger.kernel.org Subject: Re: [PATCH v2] iio: dma-buffer: Cleanup buffer.h/buffer_impl.h includes Message-ID: <20200405125916.7f4c235c@archlinux> In-Reply-To: <20200401165706.30416-1-lars@metafoo.de> References: <20200401165706.30416-1-lars@metafoo.de> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 1 Apr 2020 18:57:06 +0200 Lars-Peter Clausen wrote: > The IIO DMA buffer is a DMA buffer implementation. As such it should > include buffer_impl.h rather than buffer.h. > > The include to buffer.h in buffer-dma.h should be buffer_impl.h so it has > access to the struct iio_buffer definition. The code currently only works > because all places that use buffer-dma.h include buffer_impl.h before it. > > The include to buffer.h in industrialio-buffer-dma.c can be removed since > those file does not reference any of buffer consumer functions. > > Signed-off-by: Lars-Peter Clausen Applied. Thanks, Jonathan > --- > Changes since v1: > * Don't remove buffer.h include in buffer-dma.h since it is needed > after all. > --- > drivers/iio/buffer/industrialio-buffer-dma.c | 1 - > include/linux/iio/buffer-dma.h | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iio/buffer/industrialio-buffer-dma.c b/drivers/iio/buffer/industrialio-buffer-dma.c > index a74bd9c0587c..d348af8b9705 100644 > --- a/drivers/iio/buffer/industrialio-buffer-dma.c > +++ b/drivers/iio/buffer/industrialio-buffer-dma.c > @@ -12,7 +12,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/include/linux/iio/buffer-dma.h b/include/linux/iio/buffer-dma.h > index 016d8a068353..ff15c61bf319 100644 > --- a/include/linux/iio/buffer-dma.h > +++ b/include/linux/iio/buffer-dma.h > @@ -11,7 +11,7 @@ > #include > #include > #include > -#include > +#include > > struct iio_dma_buffer_queue; > struct iio_dma_buffer_ops;