From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/5] iio: xilinx-xadc: Fix ADC-B powerdown
Date: Sun, 5 Apr 2020 18:20:07 +0100 [thread overview]
Message-ID: <20200405182007.3d0ce357@archlinux> (raw)
In-Reply-To: <195740ae-392f-5d6b-6042-f09e315847dd@metafoo.de>
On Sun, 5 Apr 2020 14:29:00 +0200
Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 4/5/20 2:26 PM, Jonathan Cameron wrote:
> > On Sun, 5 Apr 2020 14:13:32 +0200
> > Lars-Peter Clausen <lars@metafoo.de> wrote:
> >
> >> On 4/5/20 2:10 PM, Jonathan Cameron wrote:
> >>> On Fri, 3 Apr 2020 15:27:13 +0200
> >>> Lars-Peter Clausen <lars@metafoo.de> wrote:
> >>>
> >>>> The check for shutting down the second ADC is inverted. This causes it to
> >>>> be powered down when it should be enabled. As a result channels that are
> >>>> supposed to be handled by the second ADC return invalid conversion results.
> >>>>
> >>>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> >>> Fixes tag? Definitely sounds like something we should be backporting!
> >> Fixes: bdc8cda1d010 ("iio:adc: Add Xilinx XADC driver")
> > For all of them? (just checking)
> Yes, took 6 years for somebody to notice :)
We've had ones that took longer :)
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
prev parent reply other threads:[~2020-04-05 17:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 13:27 [PATCH 1/5] iio: xilinx-xadc: Fix ADC-B powerdown Lars-Peter Clausen
2020-04-03 13:27 ` [PATCH 2/5] iio: xilinx-xadc: Fix clearing interrupt when enabling trigger Lars-Peter Clausen
2020-04-05 12:11 ` Jonathan Cameron
2020-04-03 13:27 ` [PATCH 3/5] iio: xilinx-xadc: Fix sequencer configuration for aux channels in simultaneous mode Lars-Peter Clausen
2020-04-05 12:13 ` Jonathan Cameron
2020-04-03 13:27 ` [PATCH 4/5] iio: xilinx-xadc: Make sure not exceed maximum samplerate Lars-Peter Clausen
2020-04-05 12:15 ` Jonathan Cameron
2020-04-03 13:27 ` [PATCH 5/5] iio: xilinx-xadc: Fix typo Lars-Peter Clausen
2020-04-05 12:17 ` Jonathan Cameron
2020-04-05 12:10 ` [PATCH 1/5] iio: xilinx-xadc: Fix ADC-B powerdown Jonathan Cameron
2020-04-05 12:13 ` Lars-Peter Clausen
2020-04-05 12:26 ` Jonathan Cameron
2020-04-05 12:29 ` Lars-Peter Clausen
2020-04-05 17:20 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200405182007.3d0ce357@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox