Re: [PATCH 2/3] iio: DAC extension for ltc2634-12/10/8

Andy Shevchenko
2020-04-14T15:07:30Z

On Tue, Apr 14, 2020 at 5:51 PM Peter Meerwald-Stadler
<pmeerw@pmeerw.net> wrote:

...

> > @@ -357,6 +393,12 @@ static const struct spi_device_id ltc2632_id[] = {
> > { "ltc2632-h12", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2632H12] },
> > { "ltc2632-h10", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2632H10] },
> > { "ltc2632-h8", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2632H8] },
> > + { "ltc2634-l12", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2634L12] },
>
> is kernel_ulong_t the correct type here?

Pretty much.

> i.e. guaranteed to hold a pointer value, such as uintptr_t in C?

> it seems so, but why not use uintptr_t?

Because of inconsistency with a definition of structure. Please, refer
to mod_devicetable.h for the details.

> > + { "ltc2634-l10", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2634L10] },
> > + { "ltc2634-l8", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2634L8] },
> > + { "ltc2634-h12", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2634H12] },
> > + { "ltc2634-h10", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2634H10] },
> > + { "ltc2634-h8", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2634H8] },
> > { "ltc2636-l12", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2636L12] },
> > { "ltc2636-l10", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2636L10] },
> > { "ltc2636-l8", (kernel_ulong_t)&ltc2632_chip_info_tbl[ID_LTC2636L8] },

--
With Best Regards,
Andy Shevchenko