Re: [PATCH v4 2/4] iio: vcnl4000: Add event support for VCNL4010/20.

Andy Shevchenko
2020-04-22T08:26:08Z

On Wed, Apr 22, 2020 at 11:02 AM Mathieu Othacehe <m.othacehe@gmail.com> wrote:

> >> + ret = devm_request_threaded_irq(&client->dev, client->irq,
> >> + NULL, vcnl4010_irq_thread,
> >> + IRQF_TRIGGER_FALLING |
> >
> >> + IRQF_ONESHOT,
> >
> > Isn't it by default when threaded IRQ is asked with NULL for hw handler?
>
> No, and it fails with this error message if IRQF_ONESHOT is not set:
>
> pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n",

Ok, thanks.

--
With Best Regards,
Andy Shevchenko