From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: <jic23@kernel.org>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: chemical: atlas-sensor: correct DO-SM channels
Date: Wed, 22 Apr 2020 18:27:42 +0100 [thread overview]
Message-ID: <20200422182742.00004e9b@huawei.com> (raw)
In-Reply-To: <20200419232847.32206-1-matt.ranostay@konsulko.com>
On Mon, 20 Apr 2020 02:28:47 +0300
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> IIO_CONCENTRATION channel for the DO-SM shouldn't be indexed as
> there isn't more than one, and also ATLAS_CONCENTRATION_CHANNEL
> macro scan_index define steps on the IIO_TIMESTAMP channel.
>
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Fixes tag?
J
> ---
> drivers/iio/chemical/atlas-sensor.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/chemical/atlas-sensor.c
> b/drivers/iio/chemical/atlas-sensor.c index
> 82d470561ad3..7b199ce16ecf 100644 ---
> a/drivers/iio/chemical/atlas-sensor.c +++
> b/drivers/iio/chemical/atlas-sensor.c @@ -194,7 +194,19 @@ static
> const struct iio_chan_spec atlas_orp_channels[] = { };
>
> static const struct iio_chan_spec atlas_do_channels[] = {
> - ATLAS_CONCENTRATION_CHANNEL(0, ATLAS_REG_DO_DATA),
> + {
> + .type = IIO_CONCENTRATION,
> + .address = ATLAS_REG_DO_DATA,
> + .info_mask_separate =
> + BIT(IIO_CHAN_INFO_RAW) |
> BIT(IIO_CHAN_INFO_SCALE),
> + .scan_index = 0,
> + .scan_type = {
> + .sign = 'u',
> + .realbits = 32,
> + .storagebits = 32,
> + .endianness = IIO_BE,
> + },
> + },
> IIO_CHAN_SOFT_TIMESTAMP(1),
> {
> .type = IIO_TEMP,
next prev parent reply other threads:[~2020-04-22 17:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 23:28 [PATCH] iio: chemical: atlas-sensor: correct DO-SM channels Matt Ranostay
2020-04-22 17:27 ` Jonathan Cameron [this message]
2020-04-23 3:42 ` Matt Ranostay
2020-04-23 3:43 ` Matt Ranostay
2020-04-25 13:37 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422182742.00004e9b@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox