Re: [PATCH 3/3] iio: accel: mma8452: Drop of_match_ptr macro

Jonathan Cameron
2020-04-25T14:35:31Z

On Sat, 25 Apr 2020 04:14:39 +0530
Nishant Malpani <nish.malpani25@gmail.com> wrote:

> Enables ACPI DSDT to probe via PRP0001 and the compatible property.
>
> Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com>

No on this one. There is a whole load of device tree specific code in
the driver. Now that could be moved over to the device properties
approach but that's a much less trivial job. Its probably too major
to do without someone giving a tested-by, or whoever does it
having the device to test - or setting up emulation to check
everything works as expected before and after the change.

So far I've been restricting this tidying up to the drivers that are
really simple to review (no other device tree functions called).

Jonathan

> ---
> drivers/iio/accel/mma8452.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 00e100fc845a..66217fbcc7af 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -1815,7 +1815,7 @@ MODULE_DEVICE_TABLE(i2c, mma8452_id);
> static struct i2c_driver mma8452_driver = {
> .driver = {
> .name = "mma8452",
> - .of_match_table = of_match_ptr(mma8452_dt_ids),
> + .of_match_table = mma8452_dt_ids,
> .pm = &mma8452_pm_ops,
> },
> .probe = mma8452_probe,