From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4161C55185 for ; Sat, 25 Apr 2020 14:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C466120714 for ; Sat, 25 Apr 2020 14:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587826180; bh=ThRxazgu0GnMamTGTu7DXguxYUMDttvRFkBqDcMi1xs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=XAH6FgtINDgg40GCSJwOcNUSm9tzaU1WAsWE6uO3y9IaaZ8FGHRKEfoL4LSaNu/ly hmB7qGOMFOPKHKEGd0q/FOdTVg0QBHkF3joXw6wPR3t+Twr6ts70I4r3796YCM855n VmPceTsCc0sTG9nhIBl/h/y2jSO6MF+djHbamDjA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726142AbgDYOtk (ORCPT ); Sat, 25 Apr 2020 10:49:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:40086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbgDYOtj (ORCPT ); Sat, 25 Apr 2020 10:49:39 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B29620704; Sat, 25 Apr 2020 14:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587826179; bh=ThRxazgu0GnMamTGTu7DXguxYUMDttvRFkBqDcMi1xs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UHgKxx858atr1UQSnwzYD0eeCrdg+aAQ0Zv7GKN+kWITXAj1FVFiyoWwTJspfe0Rc EbxabUXYTIifPl5vRz5Q6lRViv+SYsYALTvid5BEZs/HpMh3jpk0iQlB5pb9eCZ5uh 7s721/KKk9AvprbVH7byDRhtCsEZrPrZnsynfW54= Date: Sat, 25 Apr 2020 15:49:35 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Jonathan Cameron , "Ardelean, Alexandru" , "linux-iio@vger.kernel.org" Subject: Re: [PATCH 0/7] iio: light: clean out of_match_ptr and tidy headers Message-ID: <20200425154935.5da9efd3@archlinux> In-Reply-To: References: <20200419150206.43033-1-jic23@kernel.org> <03f6eb6e7cf61c6dfd8bcd9aeaaf6977cb095191.camel@analog.com> <20200420164832.00004065@Huawei.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 21 Apr 2020 03:50:57 +0300 Andy Shevchenko wrote: > On Mon, Apr 20, 2020 at 6:49 PM Jonathan Cameron > wrote: > > On Mon, 20 Apr 2020 06:22:09 +0000 > > "Ardelean, Alexandru" wrote: > > > On Mon, 2020-04-20 at 06:04 +0000, Ardelean, Alexandru wrote: > > > > On Sun, 2020-04-19 at 16:01 +0100, jic23@kernel.org wrote: > > > > One thing I noticed in the series. > > > No idea if it is needed or not; a build would tell: > > > Is '#include ' required for this change? > > > Most patches add it, but I don't feel it is needed; I could be wrong though. > > > > I addressed this in reply to patch 7. It's mainly obtained via > > i2c.h and spi.h in these drivers. They don't have any particular need > > to include it as they could deal with an opaque pointer. > > > > However, seems unlikely that'll get tidied up any time soon and > > debatable whether there is any point in doing so. > > I would use the simple rule, we include header if we have direct user of it. Sensible and easy to understand basis to make the decision. Let's go with that (though I don't want to see lots of isolated 'fixes' for 'missing' headers!) > > > > What I noticed is that all 'linux/of.h' , 'linux/of_device.h' & > > > 'linux/of_platform.h' include it. > > > > True, but we shouldn't include any of them unless we have reason to do > > so. They bring baggage we don't need for these drivers. All applied with patch 7 amended to add the include. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with them. Thanks, Jonathan > > > -- > With Best Regards, > Andy Shevchenko