From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F345CC54FCB for ; Sat, 25 Apr 2020 16:31:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE45720714 for ; Sat, 25 Apr 2020 16:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587832286; bh=QdZ4lkq2YTUstUt+fB81CancoOuBMTAizh96xUzjiAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=YgpHzK0/TOfMKA4DeQn7Mfm+2ApR2Ui4Y+i+dKLCJJLKLqgCyMz0MbpuEUrM8f4Jb wqSKLOAIOZSsx5Tgw3oYcvpbO6yDEFwA5iJ4zOp2m3kRZ915Z0cmlgUe652eVuWI1F aAoEZQsu59/PAeFSbdjCPc6uisBJ8ivXMpydQRx4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbgDYQb0 (ORCPT ); Sat, 25 Apr 2020 12:31:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:54290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbgDYQb0 (ORCPT ); Sat, 25 Apr 2020 12:31:26 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D607C20644; Sat, 25 Apr 2020 16:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587832285; bh=QdZ4lkq2YTUstUt+fB81CancoOuBMTAizh96xUzjiAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Q46JTUaEoIxGR2exGKM9vChWwqAe3zabJKcdFb0YUyGqLa/yrvNNGt0dlgD89FYGh VcOTL7bTAk8ggktsXHPd6Ew0WvbLMnAlyFNhSDMQxBvYqsELEkHpq9wACZAw2fnLl6 ySvacR6fPqWOCl/C4RSMg0QV4ph6F2rxEaQs6jwo= Date: Sat, 25 Apr 2020 17:31:22 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Peter Meerwald-Stadler , linux-iio@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich Subject: Re: [PATCH v1 06/16] iio: dac: ad5446: Use put_unaligned_be24() Message-ID: <20200425173122.59cb5ddf@archlinux> In-Reply-To: <20200421003135.23060-6-andriy.shevchenko@linux.intel.com> References: <20200421003135.23060-1-andriy.shevchenko@linux.intel.com> <20200421003135.23060-6-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 21 Apr 2020 03:31:25 +0300 Andy Shevchenko wrote: > This makes the driver code slightly easier to read. > > Cc: Lars-Peter Clausen > Cc: Michael Hennerich > Signed-off-by: Andy Shevchenko You've guessed it. Applied with missing header added. Thanks, J > --- > drivers/iio/dac/ad5446.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c > index 61c670f7fc5f..87ff863bdc10 100644 > --- a/drivers/iio/dac/ad5446.c > +++ b/drivers/iio/dac/ad5446.c > @@ -302,9 +302,7 @@ static int ad5660_write(struct ad5446_state *st, unsigned val) > struct spi_device *spi = to_spi_device(st->dev); > uint8_t data[3]; > > - data[0] = (val >> 16) & 0xFF; > - data[1] = (val >> 8) & 0xFF; > - data[2] = val & 0xFF; > + put_unaligned_be24(val, &data[0]); > > return spi_write(spi, data, sizeof(data)); > }